From 0682fe544a52a9d018bb05ddcacf4c697a826094 Mon Sep 17 00:00:00 2001 From: Kenneth Chew Date: Tue, 19 Apr 2022 22:20:00 -0400 Subject: [PATCH] Fix crash if no Minecraft version is selected in the new instance screen --- launcher/ui/pages/modplatform/VanillaPage.cpp | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/launcher/ui/pages/modplatform/VanillaPage.cpp b/launcher/ui/pages/modplatform/VanillaPage.cpp index 175fda7d..a026947f 100644 --- a/launcher/ui/pages/modplatform/VanillaPage.cpp +++ b/launcher/ui/pages/modplatform/VanillaPage.cpp @@ -118,7 +118,18 @@ void VanillaPage::filterChanged() void VanillaPage::loaderFilterChanged() { - auto minecraftVersion = m_selectedVersion->descriptor(); + QString minecraftVersion; + if (m_selectedVersion) + { + minecraftVersion = m_selectedVersion->descriptor(); + } + else + { + ui->loaderVersionList->setExactFilter(BaseVersionList::ParentVersionRole, "AAA"); // empty list + ui->loaderVersionList->setEmptyString(tr("No Minecraft version is selected.")); + ui->loaderVersionList->setEmptyMode(VersionListView::String); + return; + } if(ui->noneFilter->isChecked()) { ui->loaderVersionList->setExactFilter(BaseVersionList::ParentVersionRole, "AAA"); // empty list