From 05ffcf706bff92bdc48f3063d6a64508f8b7674c Mon Sep 17 00:00:00 2001 From: Jamie Mansfield Date: Sun, 11 Oct 2020 22:43:39 +0100 Subject: [PATCH] GH-3304 Temporarily ignore download failures for FTB packs This is a temporary measure, to match FTB's own installer, to allow packs to download while FTB work on fixing the data from their API. --- api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp b/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp index fdfe560a..912beb67 100644 --- a/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp +++ b/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp @@ -123,16 +123,20 @@ void PackInstallTask::install() auto dl = Net::Download::makeFile(file.url, path); jobPtr->addNetAction(dl); } + connect(jobPtr.get(), &NetJob::succeeded, this, [&]() { jobPtr.reset(); emitSucceeded(); }); - connect(jobPtr.get(), &NetJob::failed, [&](QString reason) { jobPtr.reset(); - emitFailed(reason); + + // FIXME: Temporarily ignore file download failures (matching FTB's installer), + // while FTB's data is fucked. + qWarning() << "Failed to download files for modpack: " + reason; + emitSucceeded(); }); connect(jobPtr.get(), &NetJob::progress, [&](qint64 current, qint64 total) {