From ae719995ee6d4e17e6626d4ff81584c7dd77736d Mon Sep 17 00:00:00 2001
From: shr3dd3r <uraneban@blackhost.xyz>
Date: Wed, 30 Aug 2023 05:16:15 +0300
Subject: [PATCH] api/user/__admin_session.php and random tweaks

---
 api/_auth.php                | 10 +++++-----
 api/user/__admin_session.php | 23 +++++++++++++++++++++++
 api/user/create.php          |  4 ++++
 api/user/delete.php          | 14 +++++++++-----
 api/user/index.php           |  2 +-
 config.json                  |  1 +
 docs/API.md                  |  1 +
 7 files changed, 44 insertions(+), 11 deletions(-)
 create mode 100644 api/user/__admin_session.php

diff --git a/api/_auth.php b/api/_auth.php
index 7e7ca13..04a6bf3 100644
--- a/api/_auth.php
+++ b/api/_auth.php
@@ -21,7 +21,7 @@ function EndSession () {
 
 $LOGGED_IN = false;
 
-if (isset($_SESSION["userid"])) {
+if (session_status() == PHP_SESSION_ACTIVE && isset($_SESSION["userid"])) {
 	// Check if user still exist
 	$s = $db->prepare("SELECT * FROM users WHERE id = ?");
 	$s->bind_param("s", $_SESSION["userid"]);
@@ -32,10 +32,10 @@ if (isset($_SESSION["userid"])) {
 		die("user id used in session does not exist");
 	}
 	$LOGGED_IN = true;
-} else {
-	if (session_status()) {
-		EndSession();
-	}
+} elseif (session_status() == PHP_SESSION_ACTIVE && !isset($_SESSION["userid"])) {
+	echo "no userid, destroying session";
+	EndSession();
+	die("no userid in session");
 }
 
 ?>
\ No newline at end of file
diff --git a/api/user/__admin_session.php b/api/user/__admin_session.php
new file mode 100644
index 0000000..e67fa42
--- /dev/null
+++ b/api/user/__admin_session.php
@@ -0,0 +1,23 @@
+<?php // Start session as any user
+// ATTENTION: FOR DEBUG PURPOSES ONLY!
+require_once("../_auth.php");
+require_once("../_utils.php");
+
+
+
+if (ThisFileIsRequested(__FILE__)) {
+	require_once("../_json.php");
+
+	if (!$Config["debug"])
+		ReturnJSONError(null, "you need to enable debug mode in configuration file first");
+
+	if (!isset($_REQUEST["id"]))
+		ReturnJSONError($Err_RDP_InvalidID, "valid id must be specified");
+
+	if (!isset($_SESSION["userid"]))
+		session_start();
+
+	$_SESSION["userid"] = intval($_REQUEST["id"]);
+	ReturnJSONData($_SESSION);
+}
+?>
\ No newline at end of file
diff --git a/api/user/create.php b/api/user/create.php
index 2039f8f..96d850d 100644
--- a/api/user/create.php
+++ b/api/user/create.php
@@ -26,6 +26,10 @@ function User_Create ($login, $password, $email = null, $invite_id = null, $avat
 if (ThisFileIsRequested(__FILE__)) {
 	require_once("../_json.php");
 
+	// Dirty hack for debugging purposes. Will be removed later
+	if ($Config["debug"])
+		$_POST = $_REQUEST;
+
 	// If registration turned off
 	if (!$Config["registration"]["active"]) {
 		ReturnJSONError($Err_DP_RegClosed, "registrations are closed");
diff --git a/api/user/delete.php b/api/user/delete.php
index e020a7b..430ddcb 100644
--- a/api/user/delete.php
+++ b/api/user/delete.php
@@ -1,4 +1,4 @@
-<?php
+<?php // Deleting existing account
 require_once("../_auth.php");
 require_once("../_utils.php");
 require_once("./index.php");
@@ -17,12 +17,16 @@ function User_Delete ($id) {
 
 if (ThisFileIsRequested(__FILE__)) {
 	require_once("../_json.php");
+
+	// Dirty hack for debugging purposes. Will be removed later
+	if ($Config["debug"])
+		$_POST = $_REQUEST;
 	
-	if (isset($_REQUEST["id"]) && $LOGGED_IN) {
-		if (!ctype_digit($_REQUEST["id"]))
+	if (isset($_POST["id"]) && $LOGGED_IN) {
+		if (!ctype_digit($_POST["id"]))
 			ReturnJSONError($Err_RDP_InvalidID, "id must be numeric");
-		$UserID = intval($_REQUEST["id"]);
-	} elseif (!isset($_REQUEST["id"]) && $LOGGED_IN) {
+		$UserID = intval($_POST["id"]);
+	} elseif (!isset($_POST["id"]) && $LOGGED_IN) {
 		$UserID = $_SESSION["userid"];
 	} else {
 		ReturnJSONError($Err_RDP_InvalidID, "valid session must be provided");
diff --git a/api/user/index.php b/api/user/index.php
index fa0e109..5e070dd 100644
--- a/api/user/index.php
+++ b/api/user/index.php
@@ -73,7 +73,7 @@ function User_GetInfoByID ($id) {
 	$result["avatar_path"]   = $d["avatar_path"];
 	$result["role"]          = $d["role"];
 	$result["banned"]        = $d["banned"];
-	if ($id === $_SESSION["userid"] || User_IsMod($_SESSION["userid"])) { // User himself and mods can see additional info
+	if (($id === $_SESSION["userid"]) || User_IsMod($_SESSION["userid"])) { // User himself and mods can see additional info
 		$result["email"]     = $d["email"];
 		$result["invite_id"] = $d["invite_id"];
 	}
diff --git a/config.json b/config.json
index 3d749aa..76c39fd 100644
--- a/config.json
+++ b/config.json
@@ -1,4 +1,5 @@
 {
+	"debug": true,
 	"db": {
 		"addr": "localhost",
 		"name": "e949",
diff --git a/docs/API.md b/docs/API.md
index efb67f1..babbab8 100644
--- a/docs/API.md
+++ b/docs/API.md
@@ -30,6 +30,7 @@ Files starting from "_" ("_example.php") are intended for internal use only.
 - [ ] user/create.php (POST):              create new user account
 - [ ] user/edit.php (POST):                edit user profile
 - [x] user/delete.php (POST):              delete user account
+- [ ] user/__admin_session.php (GET):      start debug session as admin
 
 - [ ] post/ (GET/POST):                    get single post by id
 - [ ] post/search.php (GET/POST):          get list of posts matching the criteria