From 6154ebad23f99513a46abdd8b26b4540e1a9ac71 Mon Sep 17 00:00:00 2001 From: Tim G L Lyons Date: Fri, 1 Feb 2013 17:46:43 +0000 Subject: [PATCH] export file select dialogue does not correctly reject empty filenames - two (probably long standing) coding errors: use of method name 'strip' instead of calling it, and does not isolate the filename from the full pathname svn: r21270 --- src/ExportAssistant.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ExportAssistant.py b/src/ExportAssistant.py index 2a9d0f9cd..cc3eb9688 100644 --- a/src/ExportAssistant.py +++ b/src/ExportAssistant.py @@ -357,7 +357,8 @@ class ExportAssistant(gtk.Assistant, ManagedWindow.ManagedWindow) : filename = filechooser.get_filename() folder = filechooser.get_current_folder() #the file must be valid, not a folder, and folder must be valid - if filename and filename.strip and Utils.find_folder(filename) == '' \ + if filename and os.path.basename(filename.strip()) \ + and Utils.find_folder(filename) == '' \ and folder and Utils.find_folder(folder): #this page of the assistant is complete self.set_page_complete(filechooser, True)