From 41661dbea5688972adcbd65eca5fe8703109fd97 Mon Sep 17 00:00:00 2001 From: SleepWalker Date: Mon, 12 Jun 2017 22:02:15 +0300 Subject: [PATCH] #337: properly serialize null values in request.buildQuery --- src/services/request/request.js | 2 +- src/services/request/request.test.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/services/request/request.js b/src/services/request/request.js index 355cc40..bf732d2 100644 --- a/src/services/request/request.js +++ b/src/services/request/request.js @@ -114,7 +114,7 @@ function doFetch(url, options = {}) { * @return {string} */ function convertQueryValue(value) { - if (typeof value === 'undefined') { + if (typeof value === 'undefined' || value === null) { return ''; } diff --git a/src/services/request/request.test.js b/src/services/request/request.test.js index c764e19..918e58d 100644 --- a/src/services/request/request.test.js +++ b/src/services/request/request.test.js @@ -57,12 +57,13 @@ describe('services/request', () => { it('should build query', () => { const data = { notSet: undefined, + notSet2: null, numeric: 1, complexString: 'sdfgs sdfg ', positive: true, negative: false }; - const expectedQs = 'notSet=&numeric=1&complexString=sdfgs%20sdfg%20&positive=1&negative=0'; + const expectedQs = 'notSet=¬Set2=&numeric=1&complexString=sdfgs%20sdfg%20&positive=1&negative=0'; expect(request.buildQuery(data), 'to equal', expectedQs); });