From 7f42aadfcfd987870a31f3f0f5479be0b6b5e431 Mon Sep 17 00:00:00 2001 From: ErickSkrauch Date: Sun, 8 Jul 2018 18:55:53 +0300 Subject: [PATCH] Fix code style --- common/tasks/DeliveryWebHook.php | 1 + console/controllers/WebhooksController.php | 2 +- tests/codeception/common/unit/tasks/DeliveryWebHookTest.php | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/common/tasks/DeliveryWebHook.php b/common/tasks/DeliveryWebHook.php index 7561d2a..a3d639b 100644 --- a/common/tasks/DeliveryWebHook.php +++ b/common/tasks/DeliveryWebHook.php @@ -78,6 +78,7 @@ class DeliveryWebHook implements RetryableJobInterface { ]); } catch (ClientException $e) { Yii::info("Delivery for {$this->url} has failed with {$e->getResponse()->getStatusCode()} status."); + return; } } diff --git a/console/controllers/WebhooksController.php b/console/controllers/WebhooksController.php index 6f77acc..1dcd731 100644 --- a/console/controllers/WebhooksController.php +++ b/console/controllers/WebhooksController.php @@ -38,7 +38,7 @@ class WebhooksController extends Controller { if ($eventIndex !== '') { $events[] = $options[$eventIndex]; } - } while($eventIndex !== '' || empty($events)); // User must choose at least one event + } while ($eventIndex !== '' || empty($events)); $form->url = $url; $form->events = $events; diff --git a/tests/codeception/common/unit/tasks/DeliveryWebHookTest.php b/tests/codeception/common/unit/tasks/DeliveryWebHookTest.php index af74384..f798b60 100644 --- a/tests/codeception/common/unit/tasks/DeliveryWebHookTest.php +++ b/tests/codeception/common/unit/tasks/DeliveryWebHookTest.php @@ -109,7 +109,8 @@ class DeliveryWebHookTest extends TestCase { private function createMockedTask(): DeliveryWebHook { $container = &$this->historyContainer; $response = $this->response; - return new class ($container, $response) extends DeliveryWebHook { + + return new class($container, $response) extends DeliveryWebHook { private $historyContainer; private $response;