From 1a9224e453276514def696176341640c88b96b86 Mon Sep 17 00:00:00 2001 From: WeebDataHoarder Date: Sun, 27 Apr 2025 21:41:30 +0200 Subject: [PATCH] challenge: fix skipped challenged being logged as issued due to inner condition --- lib/action/challenge.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/action/challenge.go b/lib/action/challenge.go index f54d840..51fe9ba 100644 --- a/lib/action/challenge.go +++ b/lib/action/challenge.go @@ -142,8 +142,10 @@ func (a Challenge) Handle(logger *slog.Logger, w http.ResponseWriter, r *http.Re expiry := data.Expiration(reg.Duration) key := challenge.GetChallengeKeyForRequest(data.State, reg, expiry, r) - data.State.ChallengeIssued(r, reg, r.URL.String(), logger) result = reg.IssueChallenge(w, r, key, expiry) + if result != challenge.VerifyResultSkip { + data.State.ChallengeIssued(r, reg, r.URL.String(), logger) + } data.ChallengeVerify[reg.Id()] = result data.ChallengeState[reg.Id()] = challenge.VerifyStatePass switch result {