From 8ce1ad3097ca6b92293ca767f6e4ddd98ad0d90e Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 16 Nov 2010 07:15:00 -0500 Subject: [PATCH] depmod.pl: add recursive sanity check If modules contain circular dependencies, the depmod script will follow the circle forever. So add a simple sanity check to abort rather than chew up the CPU. Signed-off-by: Mike Frysinger --- examples/depmod.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/depmod.pl b/examples/depmod.pl index 8c6548d28..f324b121a 100755 --- a/examples/depmod.pl +++ b/examples/depmod.pl @@ -173,6 +173,9 @@ sub add_mod_deps $depth .= " "; warn "${depth}loading deps of module: $this_module\n" if $verbose; + if (length($depth) > 50) { + die "too much recursion (circular dependencies in modules?)"; + } foreach my $md (keys %{$mod->{$this_module}}) { add_mod_deps ($depth, $mod, $mod2, $module, $md);