From ac78f2ac96b3efd6551a08e7dc609efa1fb69481 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Sun, 11 Aug 2019 16:17:11 +0200 Subject: [PATCH] top: do not use previous colleced data wheh "h" toggles threads display This prevents first update from showing incorrect CPU usage data function old new delta handle_input 620 643 +23 Signed-off-by: Denys Vlasenko --- procps/top.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/procps/top.c b/procps/top.c index 8fe53324f..5c41e8e10 100644 --- a/procps/top.c +++ b/procps/top.c @@ -979,6 +979,9 @@ static unsigned handle_input(unsigned scan_mask, duration_t interval) IF_FEATURE_TOPMEM(&& scan_mask != TOPMEM_MASK) ) { scan_mask ^= PSSCAN_TASKS; + free(prev_hist); + prev_hist = NULL; + prev_hist_count = 0; continue; } # endif @@ -1000,10 +1003,10 @@ static unsigned handle_input(unsigned scan_mask, duration_t interval) # if ENABLE_FEATURE_TOPMEM if (c == 's') { scan_mask = TOPMEM_MASK; + sort_field = (sort_field + 1) % NUM_SORT_FIELD; free(prev_hist); prev_hist = NULL; prev_hist_count = 0; - sort_field = (sort_field + 1) % NUM_SORT_FIELD; continue; } # endif