From c4144ca3a51cf5bfe7dfa5a796ae53e9ae33126c Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Sun, 14 Jan 2018 19:40:00 +0100 Subject: [PATCH] renice: add comment about getpwnam/NOFORK interaction Signed-off-by: Denys Vlasenko --- util-linux/renice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util-linux/renice.c b/util-linux/renice.c index 65a80001b..46704591f 100644 --- a/util-linux/renice.c +++ b/util-linux/renice.c @@ -6,7 +6,6 @@ * * Licensed under GPLv2 or later, see file LICENSE in this source tree. */ - /* Notes: * Setting an absolute priority was obsoleted in SUSv2 and removed * in SUSv3. However, the common linux version of renice does @@ -95,6 +94,7 @@ int renice_main(int argc UNUSED_PARAM, char **argv) /* Process an ID arg. */ if (which == PRIO_USER) { struct passwd *p; + /* NB: use of getpwnam makes it risky to be NOFORK, switch to getpwnam_r? */ p = getpwnam(arg); if (!p) { bb_error_msg("unknown user %s", arg);