From cfd392bea9f52539baae9be4833075e464075958 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 3 Aug 2017 19:56:29 +0200 Subject: [PATCH] ash: add a fixme comment at run_nofork_applet Signed-off-by: Denys Vlasenko --- shell/ash.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shell/ash.c b/shell/ash.c index b285e3d33..8c9f4adc6 100644 --- a/shell/ash.c +++ b/shell/ash.c @@ -9918,11 +9918,13 @@ evalcommand(union node *cmd, int flags) if (applet_no >= 0 && APPLET_IS_NOFORK(applet_no)) { listsetvar(varlist.list, VEXPORT|VSTACK); /* run _main() */ +//FIXME: do we need INT_OFF / INT_ON here? +//wouldn't open files and allocations leak on ^C otherwise? status = run_nofork_applet(applet_no, argv); break; } #endif - /* Can we avoid forking off? For example, very last command + /* Can we avoid forking? For example, very last command * in a script or a subshell does not need forking, * we can just exec it. */