From efe99b59c6cd3d9de91ebfc39f9870b8708e5b92 Mon Sep 17 00:00:00 2001 From: Joachim Nilsson Date: Sat, 9 May 2020 16:49:24 +0200 Subject: [PATCH] syslogd: delay PID file creation until syslogd is ready This patch moves the creation of the PID file until after syslogd has set up signal handlers and is ready. Signed-off-by: Joachim Nilsson Signed-off-by: Denys Vlasenko --- sysklogd/syslogd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sysklogd/syslogd.c b/sysklogd/syslogd.c index f61da9de5..598f28d0c 100644 --- a/sysklogd/syslogd.c +++ b/sysklogd/syslogd.c @@ -1034,6 +1034,7 @@ static void do_syslogd(void) kmsg_init(); timestamp_and_log_internal("syslogd started: BusyBox v" BB_VER); + write_pidfile_std_path_and_ext("syslogd"); while (!bb_got_signal) { ssize_t sz; @@ -1182,9 +1183,6 @@ int syslogd_main(int argc UNUSED_PARAM, char **argv) bb_daemonize_or_rexec(DAEMON_CHDIR_ROOT, argv); } - //umask(0); - why?? - write_pidfile_std_path_and_ext("syslogd"); - do_syslogd(); /* return EXIT_SUCCESS; */ }