From d2988dc7ddd832ffc94f6b76c54898217812b7cc Mon Sep 17 00:00:00 2001 From: William Hubbs Date: Fri, 18 Oct 2013 16:26:46 -0500 Subject: [PATCH] remove redundant sync calls The localmount and mount-ro scripts were flushing pending disk writes by calling sync twice in succession. This is no longer necessary; see the bug report and blog post for reasons we were still doing this. Reported-by: Patrick Lauer X-Gentoo-Bug: 487382 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=487382 --- init.d/localmount.in | 2 +- init.d/mount-ro.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/init.d/localmount.in b/init.d/localmount.in index 54448892..42b79883 100644 --- a/init.d/localmount.in +++ b/init.d/localmount.in @@ -59,7 +59,7 @@ stop() no_umounts_r="^($no_umounts_r)$" # Flush all pending disk writes now - sync; sync + sync . "$RC_LIBEXECDIR"/sh/rc-mount.sh diff --git a/init.d/mount-ro.in b/init.d/mount-ro.in index f8d72586..3e093522 100644 --- a/init.d/mount-ro.in +++ b/init.d/mount-ro.in @@ -15,7 +15,7 @@ start() local ret=0 # Flush all pending disk writes now - sync; sync + sync ebegin "Remounting remaining filesystems read-only" # We need the do_unmount function