From e3b02abd7abe0cd6265cb56324018b6db003f293 Mon Sep 17 00:00:00 2001 From: William Hubbs Date: Tue, 12 Jul 2011 15:29:04 -0500 Subject: [PATCH] Add warnings for the use of bash arrays Currently, we allow the use of bash arrays for some configuration settings. This is undocumented, so I want to remove the support from openrc. The first phase of this removal will be this commit which adds warnings to encourage people not to use bash arrays. X-Gentoo-Bug: 374875 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=374875 --- init.d/net.lo.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/init.d/net.lo.in b/init.d/net.lo.in index a1ec7c3d..5969beed 100644 --- a/init.d/net.lo.in +++ b/init.d/net.lo.in @@ -48,6 +48,9 @@ _get_array() if [ -n "${BASH}" ]; then case "$(declare -p "$1" 2>/dev/null)" in "declare -a "*) + ewarn "You are using a bash array for $1." + ewarn "This feature will be removed in the future." + ewarn "Please see net.example for the correct format for $1." eval "set -- \"\${$1[@]}\"" for _a; do printf "%s\n" "${_a}" @@ -69,6 +72,9 @@ _flatten_array() if [ -n "${BASH}" ]; then case "$(declare -p "$1" 2>/dev/null)" in "declare -a "*) + ewarn "You are using a bash array for $1." + ewarn "This feature will be removed in the future." + ewarn "Please see net.example for the correct format for $1." eval "set -- \"\${$1[@]}\"" for x; do printf "'%s' " "$(printf "$x" | sed "s:':'\\\'':g")"