From 118854162d04ac01842e369cdb332868e0f26cfa Mon Sep 17 00:00:00 2001 From: albert <> Date: Sun, 6 Oct 2002 21:34:17 +0000 Subject: [PATCH] crossed the Rubicon, and no, it wasn't fun --- AUTHORS | 4 ++-- BUGS | 32 ++++++++++++-------------------- free.1 | 2 +- kill.1 | 4 ++-- procps.lsm | 2 +- skill.1 | 8 +++----- tload.1 | 2 +- top.1 | 4 ++-- top.c | 2 +- top.h | 2 +- uptime.1 | 2 +- w.1 | 2 +- 12 files changed, 28 insertions(+), 38 deletions(-) diff --git a/AUTHORS b/AUTHORS index 3e47666b..dd2ad4fc 100644 --- a/AUTHORS +++ b/AUTHORS @@ -8,10 +8,10 @@ Michael K. Johnson Michael Shields Charles Blake David Mossberger-Tang -Albert Cahalan +Albert Cahalan skill/kill/snice: -Albert Cahalan +Albert Cahalan tload: Branko Lankester diff --git a/BUGS b/BUGS index df7ced42..12643407 100644 --- a/BUGS +++ b/BUGS @@ -9,16 +9,21 @@ documentation! Where to send ============= -Send comments, bug reports, patches, etc., to acahalan@cs.uml.edu +Send comments, bug reports, patches, etc., to albert@users.sf.net What to send ============ -It is much more useful to me if a program really crases to recompile it +It is much more useful to me if a program really crashes to recompile it with make "CC=gcc -ggdb -O", run it with "gdb prog" and "run" and send me a stack trace ('bt' command). That said, any bug report is still better than none. +strace and ltrace output are very helpful: + + strace -o output-file ps --blah + bzip2 output-file + It might be nice to get rid of miscellaneous compiler warnings, but don't bend over backwards to do it. @@ -33,29 +38,20 @@ code was compiled. A macro is provide in libproc/version.h to construct the code from its components, e.g. - if (linux_version_code < LINUX_VERSION(1,1,30)) - /* tty field is only a minor */ + if (linux_version_code < LINUX_VERSION(2,5,41)) + /* blah blah blah */ A startup call to set_linux_version may also be necessary. Of course, if a bug is due to a change in kernel file formats, it would be best to first try to generalize the parsing, since the code is then more resilient against future change. -If you send me patches which are specific to *compiling* on a particular -version of Linux include a "#if LINUX_VERSION_CODE > 1*0x10000+3*0x100+54" -markup of the patch so that the package may be compiled with older -kernels as well as the "latest and greatest". LINUX_VERSION_CODE is -#define'd in . - -Note that you should not make patches specific to *compiling* on a -particular version of Linux unless there is nothing else you can do. - Also unified diffs (diff -u) are my preference, context diffs (diff -c ) are kind of usable, and standard diffs (diff) are more useless than a generic text description of what you did. Just use - diff -u oldfile newfile + diff -Naurd oldfile newfile or - diff -Naur old-procps-dir new-procps-dir + diff -Naurd old-procps-dir new-procps-dir to create your diffs and you will make me happy. Also make sure to include a description of what the diff is for or I'm likely to ignore it because of general lack of time... @@ -63,12 +59,8 @@ it because of general lack of time... Code Structure ============== -My ultimate goal for this package is to be compilable with any kernel -headers and to be able to run under any kernel's /proc. (Don't bother -telling me that I'm not especially close to my ultimate goal... who -is? :-) -Anyhow, another goal is to encapsulate *all* parsing dependent on /proc +A goal is to encapsulate *all* parsing dependent on /proc file formats into the libproc library. If the API is general enough it can hopefully stabilize and then /proc changes might only require updating libproc.so. Beyond that having the set of utilities be simple diff --git a/free.1 b/free.1 index f33b8d10..cc690041 100644 --- a/free.1 +++ b/free.1 @@ -41,5 +41,5 @@ The \fB\-V\fP displays version information. .SH AUTHORS Written by Brian Edmonds. -Send bug reports to +Send bug reports to diff --git a/kill.1 b/kill.1 index f6870b8b..a2b8df69 100644 --- a/kill.1 +++ b/kill.1 @@ -90,8 +90,8 @@ top(1) skill(1) kill(2) renice(1) nice(1) This command meets appropriate standards. The -L flag is Linux-specific. .SH AUTHOR -Albert Cahalan wrote kill in 1999 to replace the +Albert Cahalan wrote kill in 1999 to replace the version that was not standards compliant. Michael K. Johnson is the current maintainer of the procps collection. -Please send bug reports to +Please send bug reports to diff --git a/procps.lsm b/procps.lsm index 0d4e9ae9..9adc6992 100644 --- a/procps.lsm +++ b/procps.lsm @@ -7,7 +7,7 @@ Description: Procps is a library which parses the textual /proc filesystem Keywords: procps /proc libproc ps uptime tload free w top vmstat watch skill snice kill pgrep pkill Author: Michael K. Johnson, Charles Blake, Albert Cahalan, many others. -Maintained-by: various +Maintained-by: various Primary-site: http://procps.sf.net/ 185kB procps-3.0.0.tar.gz Alternate-site: http://www.debian.org/Packages/unstable/base/procps.html diff --git a/skill.1 b/skill.1 index 57039545..590faeaf 100644 --- a/skill.1 +++ b/skill.1 @@ -112,8 +112,6 @@ top(1) kill(1) renice(1) nice(1) No standards apply. .SH AUTHOR -Albert Cahalan wrote skill and snice in 1999 as a -replacement for a non-free version. Michael K. Johnson -is the current maintainer of the procps collection. - -Please send bug reports to +Albert Cahalan wrote skill and snice in 1999 as a +replacement for a non-free version, and is the current maintainer of the +procps collection. Please send bug reports to diff --git a/tload.1 b/tload.1 index aec34dd4..ef82b018 100644 --- a/tload.1 +++ b/tload.1 @@ -47,4 +47,4 @@ and update the display. Branko Lankester, David Engel , and Michael K. Johnson . -Please send bug reports to +Please send bug reports to diff --git a/top.1 b/top.1 index 51a5dff4..52238a36 100644 --- a/top.1 +++ b/top.1 @@ -1902,7 +1902,7 @@ them ol' bug-bytes (sic-sic)! Bugs? What bugs? But, if ever there were, then... Please send bug reports to: - Albert D\. Cahalan, + Albert D\. Cahalan, [ thanks Albert, heaven forbid author should be bothered ] @@ -1934,7 +1934,7 @@ This entirely new and enhanced replacement was written by: With invaluable help from: Craig Small, - Albert D\. Cahalan, + Albert D\. Cahalan, .ig .rj 2 diff --git a/top.c b/top.c index 2e4aa9ff..797b0418 100644 --- a/top.c +++ b/top.c @@ -15,7 +15,7 @@ */ /* For their contributions to this program, the author wishes to thank: * Craig Small, - * Albert D. Cahalan, + * Albert D. Cahalan, */ #include #include diff --git a/top.h b/top.h index 9967ae5b..49fc86e0 100644 --- a/top.h +++ b/top.h @@ -15,7 +15,7 @@ */ /* For their contributions to this program, the author wishes to thank: * Craig Small, - * Albert D. Cahalan, + * Albert D. Cahalan, */ #ifndef _Itop #define _Itop diff --git a/uptime.1 b/uptime.1 index ecb4e70b..3aae739f 100644 --- a/uptime.1 +++ b/uptime.1 @@ -26,7 +26,7 @@ This is the same information contained in the header line displayed by was written by Larry Greenfield and Michael K. Johnson . -Please send bug reports to +Please send bug reports to .SH "SEE ALSO" .BR ps (1), .BR top (1), diff --git a/w.1 b/w.1 index 647d55ef..d8a32c01 100644 --- a/w.1 +++ b/w.1 @@ -81,4 +81,4 @@ was re-written almost entirely by Charles Blake, based on the version by Larry Greenfield and Michael K. Johnson . -Please send bug reports to +Please send bug reports to