From 9e4c2cca392399d7e1cf167816913581631b842c Mon Sep 17 00:00:00 2001 From: Jim Warner Date: Fri, 3 Jan 2020 00:00:00 -0600 Subject: [PATCH] top: at abnormal end allow core dumps (fix qualys bug) A Qualys audit patch, represented in the commit below, added the _exit() call to our abnormal signal handler. Unfortunately, that disabled the associated core dump. This patch restores expected behavior of those signals whose default produces a core dump file + termination. Reference(s): commit 0847390b8335c1747a3ea0944123b2f594251bc0 Signed-off-by: Jim Warner --- top/top.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/top/top.c b/top/top.c index 09b8ef9d..8e8c7d9d 100644 --- a/top/top.c +++ b/top/top.c @@ -579,18 +579,22 @@ static void error_exit (const char *str) { /* * Catches all remaining signals not otherwise handled */ +static void sig_abexit (int sig) NORETURN; static void sig_abexit (int sig) { sigset_t ss; -// POSIX.1-2004 async-signal-safe: sigfillset, sigprocmask, signal, raise +// POSIX.1-2004 async-signal-safe: sigfillset, sigprocmask, signal, sigemptyset, sigaddset, raise sigfillset(&ss); sigprocmask(SIG_BLOCK, &ss, NULL); at_eoj(); // restore tty in preparation for exit fprintf(stderr, N_fmt(EXIT_signals_fmt) , sig, signal_number_to_name(sig), Myname); signal(sig, SIG_DFL); // allow core dumps, if applicable + sigemptyset(&ss); + sigaddset(&ss, sig); + sigprocmask(SIG_UNBLOCK, &ss, NULL); raise(sig); // ( plus set proper return code ) - _exit(sig | 0x80); // if default sig action is ignore + _exit(EXIT_FAILURE); // if default sig action is ignore } // end: sig_abexit