From adfa2bc75a57f39fa086e188834365fc01321e1c Mon Sep 17 00:00:00 2001 From: Jim Warner Date: Thu, 9 Jun 2016 00:00:00 -0500 Subject: [PATCH] library: please keep procps-private.h free of #include The 'procps.h' header includes all other headers which contain exported (public) functions, while this header has some (private) macros required for implementation. If we mix the two, by including procps.h in this file, we'll lose all hope of the compiler catching the kinds of errors corrected in an immediately preceding patch. [ we must be diligent, always constantly striving to ] [ protect jimmy from ill effects due to copy & paste ] Signed-off-by: Jim Warner --- proc/procps-private.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/proc/procps-private.h b/proc/procps-private.h index 57963695..2374f1b6 100644 --- a/proc/procps-private.h +++ b/proc/procps-private.h @@ -18,8 +18,6 @@ #ifndef PROCPS_PRIVATE_H #define PROCPS_PRIVATE_H -#include - #define FUNCTION __attribute__((__const__)) // no access to global mem, even via ptr, and no side effect #define PROCPS_EXPORT __attribute__ ((visibility("default")))