From c2707dc2d7dc92909e3f2041e699df93a8afe516 Mon Sep 17 00:00:00 2001 From: Craig Small Date: Sun, 7 Apr 2013 09:30:59 +1000 Subject: [PATCH] sysctl return value Gilles brought up a warning message in sysctl.c sysctl.c: In function 'main': sysctl.c:767: warning: value computed is not used The return value of Preload was not being applied correctly to ret meaning sysctl would not return the correct value. Reference: http://www.freelists.org/post/procps/procpsng-337,18 Signed-off-by: Craig Small --- sysctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysctl.c b/sysctl.c index 07568788..81d697e7 100644 --- a/sysctl.c +++ b/sysctl.c @@ -764,15 +764,15 @@ int main(int argc, char *argv[]) int ret = EXIT_SUCCESS, i; if (!preloadfile) { if (!argc) { - ret != Preload(DEFAULT_PRELOAD); + ret |= Preload(DEFAULT_PRELOAD); } } else { /* This happens when -pfile option is * used without space. */ - Preload(preloadfile); + ret |= Preload(preloadfile); } for (i = 0; i < argc; i++) - Preload(argv[i]); + ret |= Preload(argv[i]); return ret; }