From f68dfabc3589d46594638bcaf763323117ddefa8 Mon Sep 17 00:00:00 2001 From: Jim Warner Date: Sun, 15 May 2016 00:00:00 -0500 Subject: [PATCH] library: try different alignment for types, api Rather than adopt an approach offered below, involving changing all enumerator names to convey types, perhaps this much more modest change is a worthwhile 1st step. By just changing the comments to 'right justification' it dramatically improves readability, at least it does to my eye. Perhaps such an approach can postpone that massive alternative effort for the foreseeable future. Reference(s): http://www.freelists.org/post/procps/newlib-drip-drip,4 Signed-off-by: Jim Warner --- proc/pids.h | 236 ++++++++++++++++++++++++++-------------------------- 1 file changed, 118 insertions(+), 118 deletions(-) diff --git a/proc/pids.h b/proc/pids.h index 812b68c1..0af6a917 100644 --- a/proc/pids.h +++ b/proc/pids.h @@ -27,124 +27,124 @@ __BEGIN_DECLS enum pids_item { - PROCPS_PIDS_noop, // ( never altered ) - PROCPS_PIDS_extra, // ( reset to zero ) - PROCPS_PIDS_ADDR_END_CODE, // ul_int - PROCPS_PIDS_ADDR_KSTK_EIP, // ul_int - PROCPS_PIDS_ADDR_KSTK_ESP, // ul_int - PROCPS_PIDS_ADDR_START_CODE, // ul_int - PROCPS_PIDS_ADDR_START_STACK, // ul_int - PROCPS_PIDS_ALARM, // sl_int - PROCPS_PIDS_CGNAME, // str - PROCPS_PIDS_CGROUP, // str - PROCPS_PIDS_CGROUP_V, // strv - PROCPS_PIDS_CMD, // str - PROCPS_PIDS_CMDLINE, // str - PROCPS_PIDS_CMDLINE_V, // strv - PROCPS_PIDS_ENVIRON, // str - PROCPS_PIDS_ENVIRON_V, // strv - PROCPS_PIDS_EXIT_SIGNAL, // s_int - PROCPS_PIDS_FLAGS, // ul_int - PROCPS_PIDS_FLT_MAJ, // sl_int - PROCPS_PIDS_FLT_MAJ_C, // sl_int - PROCPS_PIDS_FLT_MAJ_DELTA, // sl_int - PROCPS_PIDS_FLT_MIN, // sl_int - PROCPS_PIDS_FLT_MIN_C, // sl_int - PROCPS_PIDS_FLT_MIN_DELTA, // sl_int - PROCPS_PIDS_ID_EGID, // u_int - PROCPS_PIDS_ID_EGROUP, // str - PROCPS_PIDS_ID_EUID, // u_int - PROCPS_PIDS_ID_EUSER, // str - PROCPS_PIDS_ID_FGID, // u_int - PROCPS_PIDS_ID_FGROUP, // str - PROCPS_PIDS_ID_FUID, // u_int - PROCPS_PIDS_ID_FUSER, // str - PROCPS_PIDS_ID_PGRP, // s_int - PROCPS_PIDS_ID_PID, // s_int - PROCPS_PIDS_ID_PPID, // s_int - PROCPS_PIDS_ID_RGID, // u_int - PROCPS_PIDS_ID_RGROUP, // str - PROCPS_PIDS_ID_RUID, // u_int - PROCPS_PIDS_ID_RUSER, // str - PROCPS_PIDS_ID_SESSION, // s_int - PROCPS_PIDS_ID_SGID, // u_int - PROCPS_PIDS_ID_SGROUP, // str - PROCPS_PIDS_ID_SUID, // u_int - PROCPS_PIDS_ID_SUSER, // str - PROCPS_PIDS_ID_TGID, // s_int - PROCPS_PIDS_ID_TPGID, // s_int - PROCPS_PIDS_LXCNAME, // str - PROCPS_PIDS_MEM_CODE, // sl_int - PROCPS_PIDS_MEM_CODE_KIB, // sl_int - PROCPS_PIDS_MEM_DATA, // sl_int - PROCPS_PIDS_MEM_DATA_KIB, // sl_int - PROCPS_PIDS_MEM_DT, // sl_int - PROCPS_PIDS_MEM_LRS, // sl_int - PROCPS_PIDS_MEM_RES, // sl_int - PROCPS_PIDS_MEM_RES_KIB, // sl_int - PROCPS_PIDS_MEM_SHR, // sl_int - PROCPS_PIDS_MEM_SHR_KIB, // sl_int - PROCPS_PIDS_MEM_VIRT, // sl_int - PROCPS_PIDS_MEM_VIRT_KIB, // sl_int - PROCPS_PIDS_NICE, // sl_int - PROCPS_PIDS_NLWP, // s_int - PROCPS_PIDS_NS_IPC, // ul_int - PROCPS_PIDS_NS_MNT, // ul_int - PROCPS_PIDS_NS_NET, // ul_int - PROCPS_PIDS_NS_PID, // ul_int - PROCPS_PIDS_NS_USER, // ul_int - PROCPS_PIDS_NS_UTS, // ul_int - PROCPS_PIDS_OOM_ADJ, // s_int - PROCPS_PIDS_OOM_SCORE, // s_int - PROCPS_PIDS_PRIORITY, // s_int - PROCPS_PIDS_PROCESSOR, // u_int - PROCPS_PIDS_RSS, // sl_int - PROCPS_PIDS_RSS_RLIM, // ul_int - PROCPS_PIDS_RTPRIO, // ul_int - PROCPS_PIDS_SCHED_CLASS, // ul_int - PROCPS_PIDS_SD_MACH, // str - PROCPS_PIDS_SD_OUID, // str - PROCPS_PIDS_SD_SEAT, // str - PROCPS_PIDS_SD_SESS, // str - PROCPS_PIDS_SD_SLICE, // str - PROCPS_PIDS_SD_UNIT, // str - PROCPS_PIDS_SD_UUNIT, // str - PROCPS_PIDS_SIGBLOCKED, // str - PROCPS_PIDS_SIGCATCH, // str - PROCPS_PIDS_SIGIGNORE, // str - PROCPS_PIDS_SIGNALS, // str - PROCPS_PIDS_SIGPENDING, // str - PROCPS_PIDS_STATE, // s_ch - PROCPS_PIDS_SUPGIDS, // str - PROCPS_PIDS_SUPGROUPS, // str - PROCPS_PIDS_TICS_ALL, // ull_int - PROCPS_PIDS_TICS_ALL_C, // ull_int - PROCPS_PIDS_TICS_DELTA, // sl_int - PROCPS_PIDS_TICS_SYSTEM, // ull_int - PROCPS_PIDS_TICS_SYSTEM_C, // ull_int - PROCPS_PIDS_TICS_USER, // ull_int - PROCPS_PIDS_TICS_USER_C, // ull_int - PROCPS_PIDS_TIME_ALL, // ull_int - PROCPS_PIDS_TIME_ELAPSED, // ull_int - PROCPS_PIDS_TIME_START, // ull_int - PROCPS_PIDS_TTY, // s_int - PROCPS_PIDS_TTY_NAME, // str - PROCPS_PIDS_TTY_NUMBER, // str - PROCPS_PIDS_VM_DATA, // sl_int - PROCPS_PIDS_VM_EXE, // sl_int - PROCPS_PIDS_VM_LIB, // sl_int - PROCPS_PIDS_VM_RSS, // sl_int - PROCPS_PIDS_VM_RSS_ANON, // sl_int - PROCPS_PIDS_VM_RSS_FILE, // sl_int - PROCPS_PIDS_VM_RSS_LOCKED, // sl_int - PROCPS_PIDS_VM_RSS_SHARED, // sl_int - PROCPS_PIDS_VM_SIZE, // sl_int - PROCPS_PIDS_VM_STACK, // sl_int - PROCPS_PIDS_VM_SWAP, // sl_int - PROCPS_PIDS_VM_USED, // sl_int - PROCPS_PIDS_VSIZE_PGS, // ul_int - PROCPS_PIDS_WCHAN_ADDR, // ul_int - PROCPS_PIDS_WCHAN_NAME, // str + PROCPS_PIDS_noop, // ( never altered ) + PROCPS_PIDS_extra, // ( reset to zero ) + PROCPS_PIDS_ADDR_END_CODE, // ul_int + PROCPS_PIDS_ADDR_KSTK_EIP, // ul_int + PROCPS_PIDS_ADDR_KSTK_ESP, // ul_int + PROCPS_PIDS_ADDR_START_CODE, // ul_int + PROCPS_PIDS_ADDR_START_STACK, // ul_int + PROCPS_PIDS_ALARM, // sl_int + PROCPS_PIDS_CGNAME, // str + PROCPS_PIDS_CGROUP, // str + PROCPS_PIDS_CGROUP_V, // strv + PROCPS_PIDS_CMD, // str + PROCPS_PIDS_CMDLINE, // str + PROCPS_PIDS_CMDLINE_V, // strv + PROCPS_PIDS_ENVIRON, // str + PROCPS_PIDS_ENVIRON_V, // strv + PROCPS_PIDS_EXIT_SIGNAL, // s_int + PROCPS_PIDS_FLAGS, // ul_int + PROCPS_PIDS_FLT_MAJ, // sl_int + PROCPS_PIDS_FLT_MAJ_C, // sl_int + PROCPS_PIDS_FLT_MAJ_DELTA, // sl_int + PROCPS_PIDS_FLT_MIN, // sl_int + PROCPS_PIDS_FLT_MIN_C, // sl_int + PROCPS_PIDS_FLT_MIN_DELTA, // sl_int + PROCPS_PIDS_ID_EGID, // u_int + PROCPS_PIDS_ID_EGROUP, // str + PROCPS_PIDS_ID_EUID, // u_int + PROCPS_PIDS_ID_EUSER, // str + PROCPS_PIDS_ID_FGID, // u_int + PROCPS_PIDS_ID_FGROUP, // str + PROCPS_PIDS_ID_FUID, // u_int + PROCPS_PIDS_ID_FUSER, // str + PROCPS_PIDS_ID_PGRP, // s_int + PROCPS_PIDS_ID_PID, // s_int + PROCPS_PIDS_ID_PPID, // s_int + PROCPS_PIDS_ID_RGID, // u_int + PROCPS_PIDS_ID_RGROUP, // str + PROCPS_PIDS_ID_RUID, // u_int + PROCPS_PIDS_ID_RUSER, // str + PROCPS_PIDS_ID_SESSION, // s_int + PROCPS_PIDS_ID_SGID, // u_int + PROCPS_PIDS_ID_SGROUP, // str + PROCPS_PIDS_ID_SUID, // u_int + PROCPS_PIDS_ID_SUSER, // str + PROCPS_PIDS_ID_TGID, // s_int + PROCPS_PIDS_ID_TPGID, // s_int + PROCPS_PIDS_LXCNAME, // str + PROCPS_PIDS_MEM_CODE, // sl_int + PROCPS_PIDS_MEM_CODE_KIB, // sl_int + PROCPS_PIDS_MEM_DATA, // sl_int + PROCPS_PIDS_MEM_DATA_KIB, // sl_int + PROCPS_PIDS_MEM_DT, // sl_int + PROCPS_PIDS_MEM_LRS, // sl_int + PROCPS_PIDS_MEM_RES, // sl_int + PROCPS_PIDS_MEM_RES_KIB, // sl_int + PROCPS_PIDS_MEM_SHR, // sl_int + PROCPS_PIDS_MEM_SHR_KIB, // sl_int + PROCPS_PIDS_MEM_VIRT, // sl_int + PROCPS_PIDS_MEM_VIRT_KIB, // sl_int + PROCPS_PIDS_NICE, // sl_int + PROCPS_PIDS_NLWP, // s_int + PROCPS_PIDS_NS_IPC, // ul_int + PROCPS_PIDS_NS_MNT, // ul_int + PROCPS_PIDS_NS_NET, // ul_int + PROCPS_PIDS_NS_PID, // ul_int + PROCPS_PIDS_NS_USER, // ul_int + PROCPS_PIDS_NS_UTS, // ul_int + PROCPS_PIDS_OOM_ADJ, // s_int + PROCPS_PIDS_OOM_SCORE, // s_int + PROCPS_PIDS_PRIORITY, // s_int + PROCPS_PIDS_PROCESSOR, // u_int + PROCPS_PIDS_RSS, // sl_int + PROCPS_PIDS_RSS_RLIM, // ul_int + PROCPS_PIDS_RTPRIO, // ul_int + PROCPS_PIDS_SCHED_CLASS, // ul_int + PROCPS_PIDS_SD_MACH, // str + PROCPS_PIDS_SD_OUID, // str + PROCPS_PIDS_SD_SEAT, // str + PROCPS_PIDS_SD_SESS, // str + PROCPS_PIDS_SD_SLICE, // str + PROCPS_PIDS_SD_UNIT, // str + PROCPS_PIDS_SD_UUNIT, // str + PROCPS_PIDS_SIGBLOCKED, // str + PROCPS_PIDS_SIGCATCH, // str + PROCPS_PIDS_SIGIGNORE, // str + PROCPS_PIDS_SIGNALS, // str + PROCPS_PIDS_SIGPENDING, // str + PROCPS_PIDS_STATE, // s_ch + PROCPS_PIDS_SUPGIDS, // str + PROCPS_PIDS_SUPGROUPS, // str + PROCPS_PIDS_TICS_ALL, // ull_int + PROCPS_PIDS_TICS_ALL_C, // ull_int + PROCPS_PIDS_TICS_DELTA, // sl_int + PROCPS_PIDS_TICS_SYSTEM, // ull_int + PROCPS_PIDS_TICS_SYSTEM_C, // ull_int + PROCPS_PIDS_TICS_USER, // ull_int + PROCPS_PIDS_TICS_USER_C, // ull_int + PROCPS_PIDS_TIME_ALL, // ull_int + PROCPS_PIDS_TIME_ELAPSED, // ull_int + PROCPS_PIDS_TIME_START, // ull_int + PROCPS_PIDS_TTY, // s_int + PROCPS_PIDS_TTY_NAME, // str + PROCPS_PIDS_TTY_NUMBER, // str + PROCPS_PIDS_VM_DATA, // sl_int + PROCPS_PIDS_VM_EXE, // sl_int + PROCPS_PIDS_VM_LIB, // sl_int + PROCPS_PIDS_VM_RSS, // sl_int + PROCPS_PIDS_VM_RSS_ANON, // sl_int + PROCPS_PIDS_VM_RSS_FILE, // sl_int + PROCPS_PIDS_VM_RSS_LOCKED, // sl_int + PROCPS_PIDS_VM_RSS_SHARED, // sl_int + PROCPS_PIDS_VM_SIZE, // sl_int + PROCPS_PIDS_VM_STACK, // sl_int + PROCPS_PIDS_VM_SWAP, // sl_int + PROCPS_PIDS_VM_USED, // sl_int + PROCPS_PIDS_VSIZE_PGS, // ul_int + PROCPS_PIDS_WCHAN_ADDR, // ul_int + PROCPS_PIDS_WCHAN_NAME, // str }; enum pids_fetch_type {