From 45c0003e53ab671c63dcd530fd9f3245d3b29e76 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Sat, 4 Feb 2023 21:25:04 +0100 Subject: [PATCH] Use reallocf(3) instead of its pattern In addition, don't set local variables just before return. Signed-off-by: Alejandro Colomar --- lib/sgetgrent.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/sgetgrent.c b/lib/sgetgrent.c index 0138f94b..5a368e97 100644 --- a/lib/sgetgrent.c +++ b/lib/sgetgrent.c @@ -37,7 +37,6 @@ static char **list (char *s) static char **members = NULL; static int size = 0; /* max members + 1 */ int i; - char **rbuf; i = 0; for (;;) { @@ -45,14 +44,9 @@ static char **list (char *s) member name, or terminating NULL). */ if (i >= size) { size = i + 100; /* at least: i + 1 */ - rbuf = realloc (members, size * sizeof (char *)); - if (!rbuf) { - free (members); - members = NULL; - size = 0; + members = reallocf (members, size * sizeof (char *)); + if (!members) return NULL; - } - members = rbuf; } if (!s || s[0] == '\0') break;