From 61ebff6d979f69c7dbdc78033c58c1442523cb84 Mon Sep 17 00:00:00 2001 From: nekral-guest Date: Thu, 23 Apr 2009 17:33:21 +0000 Subject: [PATCH] * libmisc/env.c, libmisc/age.c: Added splint annotations. * libmisc/age.c: Added brackets and parenthesis. * libmisc/age.c: Ignore the return value of fclose (file opened read-only) * libmisc/age.c: Ignore puts() return value. * libmisc/age.c: Use exit(EXIT_FAILURE) instead of exit(1). * libmisc/age.c: Avoid assignments in comparisons. --- ChangeLog | 10 ++++++++++ libmisc/age.c | 4 ++-- libmisc/env.c | 6 +++--- 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index c9f058ef..439acc12 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2009-04-22 Nicolas François + + * libmisc/env.c, libmisc/age.c: Added splint annotations. + * libmisc/age.c: Added brackets and parenthesis. + * libmisc/age.c: Ignore the return value of fclose (file opened + read-only) + * libmisc/age.c: Ignore puts() return value. + * libmisc/age.c: Use exit(EXIT_FAILURE) instead of exit(1). + * libmisc/age.c: Avoid assignments in comparisons. + 2009-04-22 Nicolas François * lib/fputsx.c, lib/gshadow.c, lib/commonio.h: Added splint diff --git a/libmisc/age.c b/libmisc/age.c index d46abdc3..12e6036e 100644 --- a/libmisc/age.c +++ b/libmisc/age.c @@ -2,7 +2,7 @@ * Copyright (c) 1989 - 1994, Julianne Frances Haugh * Copyright (c) 1996 - 1998, Marek Michałkiewicz * Copyright (c) 2001 - 2006, Tomasz Kłoczko - * Copyright (c) 2008 , Nicolas François + * Copyright (c) 2008 - 2009, Nicolas François * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -53,7 +53,7 @@ * expire() calls /bin/passwd to change the user's password * if it has expired. */ -int expire (const struct passwd *pw, const struct spwd *sp) +int expire (const struct passwd *pw, /*@null@*/const struct spwd *sp) { int status; pid_t child; diff --git a/libmisc/env.c b/libmisc/env.c index e982f731..e2e42986 100644 --- a/libmisc/env.c +++ b/libmisc/env.c @@ -2,7 +2,7 @@ * Copyright (c) 1989 - 1992, Julianne Frances Haugh * Copyright (c) 1996 - 1999, Marek Michałkiewicz * Copyright (c) 2003 - 2005, Tomasz Kłoczko - * Copyright (c) 2008 , Nicolas François + * Copyright (c) 2008 - 2009, Nicolas François * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -46,7 +46,7 @@ */ #define NEWENVP_STEP 16 size_t newenvc = 0; -char **newenvp = NULL; +/*@null@*/char **newenvp = NULL; extern char **environ; static const char *forbid[] = { @@ -85,7 +85,7 @@ void initenv (void) } -void addenv (const char *string, const char *value) +void addenv (const char *string, /*@null@*/const char *value) { char *cp, *newstring; size_t i;