From 6461841ccdc160c957697d096dfc8dba067e7c3d Mon Sep 17 00:00:00 2001
From: nekral-guest <nekral-guest@5a98b0ae-9ef6-0310-add3-de5d479b70d7>
Date: Wed, 6 Aug 2008 15:55:57 +0000
Subject: [PATCH]  * Merge two is_shadowgrp blocks.  * Indicate that we
 continue when *_unlock fail

---
 src/gpasswd.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/gpasswd.c b/src/gpasswd.c
index f01e570b..f7667203 100644
--- a/src/gpasswd.c
+++ b/src/gpasswd.c
@@ -438,17 +438,17 @@ static void close_files (void)
 		fail_exit (1);
 	}
 #ifdef SHADOWGRP
-	if (is_shadowgrp && (sgr_close () == 0)) {
-		fprintf (stderr, _("%s: cannot rewrite the shadow group file\n"), Prog);
-		SYSLOG ((LOG_WARN, "cannot rewrite the shadow group file"));
-#ifdef WITH_AUDIT
-		audit_logger (AUDIT_USER_CHAUTHTOK, Prog,
-		              "rewriting /etc/gshadow",
-		              group, AUDIT_NO_ID, 0);
-#endif
-		fail_exit (1);
-	}
 	if (is_shadowgrp) {
+		if (sgr_close () == 0) {
+			fprintf (stderr, _("%s: cannot rewrite the shadow group file\n"), Prog);
+			SYSLOG ((LOG_WARN, "cannot rewrite the shadow group file"));
+#ifdef WITH_AUDIT
+			audit_logger (AUDIT_USER_CHAUTHTOK, Prog,
+			              "rewriting /etc/gshadow",
+			              group, AUDIT_NO_ID, 0);
+#endif
+			fail_exit (1);
+		}
 		if (sgr_unlock () == 0) {
 			fprintf (stderr, _("%s: cannot unlock the shadow group file\n"), Prog);
 			SYSLOG ((LOG_WARN, "cannot unlock the shadow group file"));
@@ -457,6 +457,7 @@ static void close_files (void)
 			              "unlocking gshadow file",
 			              group, AUDIT_NO_ID, 0);
 #endif
+			/* continue */
 		}
 		gshadow_locked = false;
 	}
@@ -469,6 +470,7 @@ static void close_files (void)
 		              "unlocking group file",
 		              group, AUDIT_NO_ID, 0);
 #endif
+		/* continue */
 	}
 	group_locked = false;
 }