[svn-upgrade] Integrating new upstream version, shadow (4.0.8)

This commit is contained in:
nekral-guest
2007-10-07 11:46:07 +00:00
parent 0ee095abd8
commit 8e167d28af
414 changed files with 21641 additions and 27358 deletions

View File

@@ -2,8 +2,7 @@
#include <config.h>
#include "rcsid.h"
RCSID("$Id: commonio.c,v 1.27 2004/11/02 19:01:12 kloczek Exp $")
RCSID ("$Id: commonio.c,v 1.28 2005/03/31 05:14:49 kloczek Exp $")
#include "defines.h"
#include <sys/stat.h>
#include <utime.h>
@@ -18,30 +17,30 @@ RCSID("$Id: commonio.c,v 1.27 2004/11/02 19:01:12 kloczek Exp $")
#endif
#ifdef WITH_SELINUX
#include <selinux/selinux.h>
static security_context_t old_context=NULL;
static security_context_t old_context = NULL;
#endif
#include "commonio.h"
/* local function prototypes */
static int check_link_count(const char *);
static int do_lock_file(const char *, const char *);
static FILE *fopen_set_perms(const char *, const char *, const struct stat *);
static int create_backup(const char *, FILE *);
static void free_linked_list(struct commonio_db *);
static void add_one_entry(struct commonio_db *, struct commonio_entry *);
static int name_is_nis(const char *);
static int write_all(const struct commonio_db *);
static struct commonio_entry *find_entry_by_name(struct commonio_db *, const char *);
static int check_link_count (const char *);
static int do_lock_file (const char *, const char *);
static FILE *fopen_set_perms (const char *, const char *, const struct stat *);
static int create_backup (const char *, FILE *);
static void free_linked_list (struct commonio_db *);
static void add_one_entry (struct commonio_db *, struct commonio_entry *);
static int name_is_nis (const char *);
static int write_all (const struct commonio_db *);
static struct commonio_entry *find_entry_by_name (struct commonio_db *,
const char *);
static int lock_count = 0;
static int nscd_need_reload = 0;
static int
check_link_count(const char *file)
static int check_link_count (const char *file)
{
struct stat sb;
if (stat(file, &sb) != 0)
if (stat (file, &sb) != 0)
return 0;
if (sb.st_nlink != 2)
@@ -51,8 +50,7 @@ check_link_count(const char *file)
}
static int
do_lock_file(const char *file, const char *lock)
static int do_lock_file (const char *file, const char *lock)
{
int fd;
int pid;
@@ -60,100 +58,99 @@ do_lock_file(const char *file, const char *lock)
int retval;
char buf[32];
if ((fd = open(file, O_CREAT|O_EXCL|O_WRONLY, 0600)) == -1)
if ((fd = open (file, O_CREAT | O_EXCL | O_WRONLY, 0600)) == -1)
return 0;
pid = getpid();
snprintf(buf, sizeof buf, "%d", pid);
len = strlen(buf) + 1;
if (write(fd, buf, len) != len) {
close(fd);
unlink(file);
pid = getpid ();
snprintf (buf, sizeof buf, "%d", pid);
len = strlen (buf) + 1;
if (write (fd, buf, len) != len) {
close (fd);
unlink (file);
return 0;
}
close(fd);
close (fd);
if (link(file, lock) == 0) {
retval = check_link_count(file);
unlink(file);
if (link (file, lock) == 0) {
retval = check_link_count (file);
unlink (file);
return retval;
}
if ((fd = open(lock, O_RDWR)) == -1) {
unlink(file);
if ((fd = open (lock, O_RDWR)) == -1) {
unlink (file);
errno = EINVAL;
return 0;
}
len = read(fd, buf, sizeof(buf) - 1);
close(fd);
len = read (fd, buf, sizeof (buf) - 1);
close (fd);
if (len <= 0) {
unlink(file);
unlink (file);
errno = EINVAL;
return 0;
}
buf[len] = '\0';
if ((pid = strtol(buf, (char **) 0, 10)) == 0) {
unlink(file);
if ((pid = strtol (buf, (char **) 0, 10)) == 0) {
unlink (file);
errno = EINVAL;
return 0;
}
if (kill(pid, 0) == 0) {
unlink(file);
if (kill (pid, 0) == 0) {
unlink (file);
errno = EEXIST;
return 0;
}
if (unlink(lock) != 0) {
unlink(file);
if (unlink (lock) != 0) {
unlink (file);
return 0;
}
retval = 0;
if (link(file, lock) == 0 && check_link_count(file))
if (link (file, lock) == 0 && check_link_count (file))
retval = 1;
unlink(file);
unlink (file);
return retval;
}
static FILE *
fopen_set_perms(const char *name, const char *mode, const struct stat *sb)
static FILE *fopen_set_perms (const char *name, const char *mode,
const struct stat *sb)
{
FILE *fp;
mode_t mask;
mask = umask(0777);
fp = fopen(name, mode);
umask(mask);
mask = umask (0777);
fp = fopen (name, mode);
umask (mask);
if (!fp)
return NULL;
#ifdef HAVE_FCHOWN
if (fchown(fileno(fp), sb->st_uid, sb->st_gid))
if (fchown (fileno (fp), sb->st_uid, sb->st_gid))
goto fail;
#else
if (chown(name, sb->st_mode))
if (chown (name, sb->st_mode))
goto fail;
#endif
#ifdef HAVE_FCHMOD
if (fchmod(fileno(fp), sb->st_mode & 0664))
if (fchmod (fileno (fp), sb->st_mode & 0664))
goto fail;
#else
if (chmod(name, sb->st_mode & 0664))
if (chmod (name, sb->st_mode & 0664))
goto fail;
#endif
return fp;
fail:
fclose(fp);
unlink(name);
fail:
fclose (fp);
unlink (name);
return NULL;
}
static int
create_backup(const char *backup, FILE *fp)
static int create_backup (const char *backup, FILE * fp)
{
struct stat sb;
struct utimbuf ub;
@@ -161,38 +158,37 @@ create_backup(const char *backup, FILE *fp)
int c;
mode_t mask;
if (fstat(fileno(fp), &sb))
if (fstat (fileno (fp), &sb))
return -1;
mask = umask(077);
bkfp = fopen(backup, "w");
umask(mask);
mask = umask (077);
bkfp = fopen (backup, "w");
umask (mask);
if (!bkfp)
return -1;
/* TODO: faster copy, not one-char-at-a-time. --marekm */
c = 0;
if (fseek(fp, 0, SEEK_SET) == 0)
while ((c = getc(fp)) != EOF) {
if (putc(c, bkfp) == EOF)
if (fseek (fp, 0, SEEK_SET) == 0)
while ((c = getc (fp)) != EOF) {
if (putc (c, bkfp) == EOF)
break;
}
if (c != EOF || ferror(fp) || fflush(bkfp)) {
fclose(bkfp);
if (c != EOF || ferror (fp) || fflush (bkfp)) {
fclose (bkfp);
return -1;
}
if (fclose(bkfp))
if (fclose (bkfp))
return -1;
ub.actime = sb.st_atime;
ub.modtime = sb.st_mtime;
utime(backup, &ub);
utime (backup, &ub);
return 0;
}
static void
free_linked_list(struct commonio_db *db)
static void free_linked_list (struct commonio_db *db)
{
struct commonio_entry *p;
@@ -201,34 +197,31 @@ free_linked_list(struct commonio_db *db)
db->head = p->next;
if (p->line)
free(p->line);
free (p->line);
if (p->eptr)
db->ops->free(p->eptr);
db->ops->free (p->eptr);
free(p);
free (p);
}
db->tail = NULL;
}
int
commonio_setname(struct commonio_db *db, const char *name)
int commonio_setname (struct commonio_db *db, const char *name)
{
snprintf(db->filename, sizeof(db->filename), "%s", name);
snprintf (db->filename, sizeof (db->filename), "%s", name);
return 1;
}
int
commonio_present(const struct commonio_db *db)
int commonio_present (const struct commonio_db *db)
{
return (access(db->filename, F_OK) == 0);
return (access (db->filename, F_OK) == 0);
}
int
commonio_lock_nowait(struct commonio_db *db)
int commonio_lock_nowait (struct commonio_db *db)
{
char file[1024];
char lock[1024];
@@ -236,9 +229,9 @@ commonio_lock_nowait(struct commonio_db *db)
if (db->locked)
return 1;
snprintf(file, sizeof file, "%s.%ld", db->filename, (long) getpid());
snprintf(lock, sizeof lock, "%s.lock", db->filename);
if (do_lock_file(file, lock)) {
snprintf (file, sizeof file, "%s.%ld", db->filename, (long) getpid ());
snprintf (lock, sizeof lock, "%s.lock", db->filename);
if (do_lock_file (file, lock)) {
db->locked = 1;
lock_count++;
return 1;
@@ -247,8 +240,7 @@ commonio_lock_nowait(struct commonio_db *db)
}
int
commonio_lock(struct commonio_db *db)
int commonio_lock (struct commonio_db *db)
{
#ifdef HAVE_LCKPWDF
/*
@@ -262,15 +254,15 @@ commonio_lock(struct commonio_db *db)
* (no retries, it should always succeed).
*/
if (lock_count == 0) {
if (lckpwdf() == -1)
return 0; /* failure */
if (lckpwdf () == -1)
return 0; /* failure */
}
if (commonio_lock_nowait(db))
return 1; /* success */
if (commonio_lock_nowait (db))
return 1; /* success */
ulckpwdf();
return 0; /* failure */
ulckpwdf ();
return 0; /* failure */
#else
int i;
@@ -286,19 +278,18 @@ commonio_lock(struct commonio_db *db)
#endif
for (i = 0; i < LOCK_TRIES; i++) {
if (i > 0)
sleep(LOCK_SLEEP); /* delay between retries */
if (commonio_lock_nowait(db))
return 1; /* success */
sleep (LOCK_SLEEP); /* delay between retries */
if (commonio_lock_nowait (db))
return 1; /* success */
/* no unnecessary retries on "permission denied" errors */
if (geteuid() != 0)
if (geteuid () != 0)
return 0;
}
return 0; /* failure */
return 0; /* failure */
#endif
}
static void
dec_lock_count(void)
static void dec_lock_count (void)
{
if (lock_count > 0) {
lock_count--;
@@ -306,48 +297,46 @@ dec_lock_count(void)
/* Tell nscd when lock count goes to zero,
if any of the files were changed. */
if (nscd_need_reload) {
nscd_flush_cache("passwd");
nscd_flush_cache("group");
nscd_flush_cache ("passwd");
nscd_flush_cache ("group");
nscd_need_reload = 0;
}
#ifdef HAVE_LCKPWDF
ulckpwdf();
ulckpwdf ();
#endif
}
}
}
int
commonio_unlock(struct commonio_db *db)
int commonio_unlock (struct commonio_db *db)
{
char lock[1024];
if (db->isopen) {
db->readonly = 1;
if (!commonio_close(db)) {
if (!commonio_close (db)) {
if (db->locked)
dec_lock_count();
dec_lock_count ();
return 0;
}
}
if (db->locked) {
if (db->locked) {
/*
* Unlock in reverse order: remove the lock file,
* then call ulckpwdf() (if used) on last unlock.
*/
db->locked = 0;
snprintf(lock, sizeof lock, "%s.lock", db->filename);
unlink(lock);
dec_lock_count();
db->locked = 0;
snprintf (lock, sizeof lock, "%s.lock", db->filename);
unlink (lock);
dec_lock_count ();
return 1;
}
return 0;
}
static void
add_one_entry(struct commonio_db *db, struct commonio_entry *p)
static void add_one_entry (struct commonio_db *db, struct commonio_entry *p)
{
p->next = NULL;
p->prev = db->tail;
@@ -359,8 +348,7 @@ add_one_entry(struct commonio_db *db, struct commonio_entry *p)
}
static int
name_is_nis(const char *n)
static int name_is_nis (const char *n)
{
return (n[0] == '+' || n[0] == '-');
}
@@ -375,15 +363,16 @@ name_is_nis(const char *n)
#endif
#if KEEP_NIS_AT_END
static void add_one_entry_nis(struct commonio_db *, struct commonio_entry *);
static void add_one_entry_nis (struct commonio_db *, struct commonio_entry *);
static void
add_one_entry_nis(struct commonio_db *db, struct commonio_entry *newp)
add_one_entry_nis (struct commonio_db *db, struct commonio_entry *newp)
{
struct commonio_entry *p;
for (p = db->head; p; p = p->next) {
if (name_is_nis(p->eptr ? db->ops->getname(p->eptr) : p->line)) {
if (name_is_nis
(p->eptr ? db->ops->getname (p->eptr) : p->line)) {
newp->next = p;
newp->prev = p->prev;
if (p->prev)
@@ -394,16 +383,15 @@ add_one_entry_nis(struct commonio_db *db, struct commonio_entry *newp)
return;
}
}
add_one_entry(db, newp);
add_one_entry (db, newp);
}
#endif /* KEEP_NIS_AT_END */
#endif /* KEEP_NIS_AT_END */
/* Initial buffer size, as well as increment if not sufficient
(for reading very long lines in group files). */
#define BUFLEN 4096
int
commonio_open(struct commonio_db *db, int mode)
int commonio_open (struct commonio_db *db, int mode)
{
char *buf;
char *cp;
@@ -429,7 +417,7 @@ commonio_open(struct commonio_db *db, int mode)
db->head = db->tail = db->cursor = NULL;
db->changed = 0;
db->fp = fopen(db->filename, db->readonly ? "r" : "r+");
db->fp = fopen (db->filename, db->readonly ? "r" : "r+");
/*
* If O_CREAT was specified and the file didn't exist, it will be
@@ -442,48 +430,47 @@ commonio_open(struct commonio_db *db, int mode)
}
return 0;
}
#ifdef WITH_SELINUX
db->scontext=NULL;
if (is_selinux_enabled() && (! db->readonly)) {
if (fgetfilecon(fileno(db->fp),&db->scontext) < 0) {
goto cleanup_errno;
}
db->scontext = NULL;
if (is_selinux_enabled () && (!db->readonly)) {
if (fgetfilecon (fileno (db->fp), &db->scontext) < 0) {
goto cleanup_errno;
}
}
#endif
buflen = BUFLEN;
buf = (char *) malloc(buflen);
buf = (char *) malloc (buflen);
if (!buf)
goto cleanup_ENOMEM;
while (db->ops->fgets(buf, buflen, db->fp)) {
while (!(cp = strrchr(buf, '\n')) && !feof(db->fp)) {
while (db->ops->fgets (buf, buflen, db->fp)) {
while (!(cp = strrchr (buf, '\n')) && !feof (db->fp)) {
int len;
buflen += BUFLEN;
cp = (char *) realloc(buf, buflen);
cp = (char *) realloc (buf, buflen);
if (!cp)
goto cleanup_buf;
buf = cp;
len = strlen(buf);
db->ops->fgets(buf + len, buflen - len, db->fp);
len = strlen (buf);
db->ops->fgets (buf + len, buflen - len, db->fp);
}
if ((cp = strrchr(buf, '\n')))
if ((cp = strrchr (buf, '\n')))
*cp = '\0';
if (!(line = strdup(buf)))
if (!(line = strdup (buf)))
goto cleanup_buf;
if (name_is_nis(line)) {
if (name_is_nis (line)) {
eptr = NULL;
} else if ((eptr = db->ops->parse(line))) {
eptr = db->ops->dup(eptr);
} else if ((eptr = db->ops->parse (line))) {
eptr = db->ops->dup (eptr);
if (!eptr)
goto cleanup_line;
}
p = (struct commonio_entry *) malloc(sizeof *p);
p = (struct commonio_entry *) malloc (sizeof *p);
if (!p)
goto cleanup_entry;
@@ -491,36 +478,36 @@ commonio_open(struct commonio_db *db, int mode)
p->line = line;
p->changed = 0;
add_one_entry(db, p);
add_one_entry (db, p);
}
free(buf);
free (buf);
if (ferror(db->fp))
if (ferror (db->fp))
goto cleanup_errno;
db->isopen = 1;
return 1;
cleanup_entry:
cleanup_entry:
if (eptr)
db->ops->free(eptr);
cleanup_line:
free(line);
cleanup_buf:
free(buf);
cleanup_ENOMEM:
db->ops->free (eptr);
cleanup_line:
free (line);
cleanup_buf:
free (buf);
cleanup_ENOMEM:
errno = ENOMEM;
cleanup_errno:
cleanup_errno:
saved_errno = errno;
free_linked_list(db);
free_linked_list (db);
#ifdef WITH_SELINUX
if (db->scontext!= NULL) {
freecon(db->scontext);
db->scontext=NULL;
if (db->scontext != NULL) {
freecon (db->scontext);
db->scontext = NULL;
}
#endif
fclose(db->fp);
fclose (db->fp);
db->fp = NULL;
errno = saved_errno;
return 0;
@@ -530,7 +517,7 @@ cleanup_errno:
* Sort given db according to cmp function (usually compares uids)
*/
int
commonio_sort(struct commonio_db *db, int (*cmp)(const void *, const void *))
commonio_sort (struct commonio_db *db, int (*cmp) (const void *, const void *))
{
struct commonio_entry **entries, *ptr;
int n = 0, i;
@@ -540,29 +527,29 @@ commonio_sort(struct commonio_db *db, int (*cmp)(const void *, const void *))
if (n <= 1)
return 0;
entries = malloc(n * sizeof(struct commonio_entry*));
entries = malloc (n * sizeof (struct commonio_entry *));
if (entries == NULL)
return -1;
n = 0;
for (ptr = db->head; ptr; ptr = ptr->next)
entries[n++] = ptr;
qsort(entries, n, sizeof(struct commonio_entry*), cmp);
qsort (entries, n, sizeof (struct commonio_entry *), cmp);
db->head = entries[0];
db->tail = entries[--n];
db->head->prev = NULL;
db->head->next = entries[1];
db->tail->prev = entries[n-1];
db->tail->prev = entries[n - 1];
db->tail->next = NULL;
for (i = 1; i < n; i++) {
entries[i]->prev = entries[i-1];
entries[i]->next = entries[i+1];
entries[i]->prev = entries[i - 1];
entries[i]->next = entries[i + 1];
}
free(entries);
free (entries);
db->changed = 1;
return 0;
@@ -571,8 +558,7 @@ commonio_sort(struct commonio_db *db, int (*cmp)(const void *, const void *))
/*
* Sort entries in db according to order in another.
*/
int
commonio_sort_wrt(struct commonio_db *shadow, struct commonio_db *passwd)
int commonio_sort_wrt (struct commonio_db *shadow, struct commonio_db *passwd)
{
struct commonio_entry *head = NULL, *pw_ptr, *spw_ptr;
const char *name;
@@ -580,34 +566,34 @@ commonio_sort_wrt(struct commonio_db *shadow, struct commonio_db *passwd)
for (pw_ptr = passwd->head; pw_ptr; pw_ptr = pw_ptr->next) {
if (pw_ptr->eptr == NULL)
continue;
name = passwd->ops->getname(pw_ptr->eptr);
name = passwd->ops->getname (pw_ptr->eptr);
for (spw_ptr = shadow->head; spw_ptr; spw_ptr = spw_ptr->next)
if (strcmp(name, shadow->ops->getname(spw_ptr->eptr)) == 0)
if (strcmp (name, shadow->ops->getname (spw_ptr->eptr))
== 0)
break;
if (spw_ptr == NULL)
if (spw_ptr == NULL)
continue;
commonio_del_entry(shadow, spw_ptr);
commonio_del_entry (shadow, spw_ptr);
spw_ptr->next = head;
head = spw_ptr;
}
for (spw_ptr = head; spw_ptr; spw_ptr = head) {
head = head->next;
if (shadow->head)
shadow->head->prev = spw_ptr;
spw_ptr->next = shadow->head;
shadow->head = spw_ptr;
}
shadow->head->prev = NULL;
shadow->changed = 1;
return 0;
}
static int
write_all(const struct commonio_db *db)
static int write_all (const struct commonio_db *db)
{
const struct commonio_entry *p;
void *eptr;
@@ -615,12 +601,12 @@ write_all(const struct commonio_db *db)
for (p = db->head; p; p = p->next) {
if (p->changed) {
eptr = p->eptr;
if (db->ops->put(eptr, db->fp))
if (db->ops->put (eptr, db->fp))
return -1;
} else if (p->line) {
if (db->ops->fputs(p->line, db->fp) == EOF)
if (db->ops->fputs (p->line, db->fp) == EOF)
return -1;
if (putc('\n', db->fp) == EOF)
if (putc ('\n', db->fp) == EOF)
return -1;
}
}
@@ -628,8 +614,7 @@ write_all(const struct commonio_db *db)
}
int
commonio_close(struct commonio_db *db)
int commonio_close (struct commonio_db *db)
{
char buf[1024];
int errors = 0;
@@ -642,41 +627,41 @@ commonio_close(struct commonio_db *db)
db->isopen = 0;
if (!db->changed || db->readonly) {
fclose(db->fp);
fclose (db->fp);
db->fp = NULL;
goto success;
}
memzero(&sb, sizeof sb);
memzero (&sb, sizeof sb);
if (db->fp) {
if (fstat(fileno(db->fp), &sb)) {
fclose(db->fp);
if (fstat (fileno (db->fp), &sb)) {
fclose (db->fp);
db->fp = NULL;
goto fail;
}
#ifdef WITH_SELINUX
if (db->scontext != NULL) {
int stat=getfscreatecon(&old_context);
if (stat< 0) {
errors++;
goto fail;
}
if (setfscreatecon(db->scontext)<0) {
errors++;
goto fail;
}
int stat = getfscreatecon (&old_context);
if (stat < 0) {
errors++;
goto fail;
}
if (setfscreatecon (db->scontext) < 0) {
errors++;
goto fail;
}
}
#endif
/*
* Create backup file.
*/
snprintf(buf, sizeof buf, "%s-", db->filename);
snprintf (buf, sizeof buf, "%s-", db->filename);
if (create_backup(buf, db->fp))
if (create_backup (buf, db->fp))
errors++;
if (fclose(db->fp))
if (fclose (db->fp))
errors++;
if (errors) {
@@ -693,77 +678,76 @@ commonio_close(struct commonio_db *db)
sb.st_gid = 0;
}
snprintf(buf, sizeof buf, "%s+", db->filename);
snprintf (buf, sizeof buf, "%s+", db->filename);
db->fp = fopen_set_perms(buf, "w", &sb);
db->fp = fopen_set_perms (buf, "w", &sb);
if (!db->fp)
goto fail;
if (write_all(db))
if (write_all (db))
errors++;
if (fflush(db->fp))
if (fflush (db->fp))
errors++;
#ifdef HAVE_FSYNC
if (fsync(fileno(db->fp)))
if (fsync (fileno (db->fp)))
errors++;
#else
sync();
sync ();
#endif
if (fclose(db->fp))
if (fclose (db->fp))
errors++;
db->fp = NULL;
if (errors) {
unlink(buf);
unlink (buf);
goto fail;
}
if (rename(buf, db->filename))
if (rename (buf, db->filename))
goto fail;
nscd_need_reload = 1;
goto success;
fail:
fail:
errors++;
success:
success:
#ifdef WITH_SELINUX
if (db->scontext != NULL) {
if (setfscreatecon(old_context)<0) {
errors++;
}
if (old_context != NULL) {
freecon(old_context);
old_context=NULL;
}
freecon(db->scontext);
db->scontext=NULL;
if (setfscreatecon (old_context) < 0) {
errors++;
}
if (old_context != NULL) {
freecon (old_context);
old_context = NULL;
}
freecon (db->scontext);
db->scontext = NULL;
}
#endif
free_linked_list(db);
return errors==0;
free_linked_list (db);
return errors == 0;
}
static struct commonio_entry *
find_entry_by_name(struct commonio_db *db, const char *name)
static struct commonio_entry *find_entry_by_name (struct commonio_db *db,
const char *name)
{
struct commonio_entry *p;
void *ep;
for (p = db->head; p; p = p->next) {
ep = p->eptr;
if (ep && strcmp(db->ops->getname(ep), name) == 0)
if (ep && strcmp (db->ops->getname (ep), name) == 0)
break;
}
return p;
}
int
commonio_update(struct commonio_db *db, const void *eptr)
int commonio_update (struct commonio_db *db, const void *eptr)
{
struct commonio_entry *p;
void *nentry;
@@ -772,13 +756,13 @@ commonio_update(struct commonio_db *db, const void *eptr)
errno = EINVAL;
return 0;
}
if (!(nentry = db->ops->dup(eptr))) {
if (!(nentry = db->ops->dup (eptr))) {
errno = ENOMEM;
return 0;
}
p = find_entry_by_name(db, db->ops->getname(eptr));
p = find_entry_by_name (db, db->ops->getname (eptr));
if (p) {
db->ops->free(p->eptr);
db->ops->free (p->eptr);
p->eptr = nentry;
p->changed = 1;
db->cursor = p;
@@ -787,9 +771,9 @@ commonio_update(struct commonio_db *db, const void *eptr)
return 1;
}
/* not found, new entry */
p = (struct commonio_entry *) malloc(sizeof *p);
p = (struct commonio_entry *) malloc (sizeof *p);
if (!p) {
db->ops->free(nentry);
db->ops->free (nentry);
errno = ENOMEM;
return 0;
}
@@ -799,9 +783,9 @@ commonio_update(struct commonio_db *db, const void *eptr)
p->changed = 1;
#if KEEP_NIS_AT_END
add_one_entry_nis(db, p);
add_one_entry_nis (db, p);
#else
add_one_entry(db, p);
add_one_entry (db, p);
#endif
db->changed = 1;
@@ -809,8 +793,7 @@ commonio_update(struct commonio_db *db, const void *eptr)
}
void
commonio_del_entry(struct commonio_db *db, const struct commonio_entry *p)
void commonio_del_entry (struct commonio_db *db, const struct commonio_entry *p)
{
if (p == db->cursor)
db->cursor = p->next;
@@ -829,8 +812,7 @@ commonio_del_entry(struct commonio_db *db, const struct commonio_entry *p)
}
int
commonio_remove(struct commonio_db *db, const char *name)
int commonio_remove (struct commonio_db *db, const char *name)
{
struct commonio_entry *p;
@@ -838,26 +820,25 @@ commonio_remove(struct commonio_db *db, const char *name)
errno = EINVAL;
return 0;
}
p = find_entry_by_name(db, name);
p = find_entry_by_name (db, name);
if (!p) {
errno = ENOENT;
return 0;
}
commonio_del_entry(db, p);
commonio_del_entry (db, p);
if (p->line)
free(p->line);
free (p->line);
if (p->eptr)
db->ops->free(p->eptr);
db->ops->free (p->eptr);
return 1;
}
const void *
commonio_locate(struct commonio_db *db, const char *name)
const void *commonio_locate (struct commonio_db *db, const char *name)
{
struct commonio_entry *p;
@@ -865,7 +846,7 @@ commonio_locate(struct commonio_db *db, const char *name)
errno = EINVAL;
return NULL;
}
p = find_entry_by_name(db, name);
p = find_entry_by_name (db, name);
if (!p) {
errno = ENOENT;
return NULL;
@@ -875,8 +856,7 @@ commonio_locate(struct commonio_db *db, const char *name)
}
int
commonio_rewind(struct commonio_db *db)
int commonio_rewind (struct commonio_db *db)
{
if (!db->isopen) {
errno = EINVAL;
@@ -887,8 +867,7 @@ commonio_rewind(struct commonio_db *db)
}
const void *
commonio_next(struct commonio_db *db)
const void *commonio_next (struct commonio_db *db)
{
void *eptr;