From 9923513271d345aedd3b3220b9814348ad093cc4 Mon Sep 17 00:00:00 2001
From: nekral-guest <nekral-guest@5a98b0ae-9ef6-0310-add3-de5d479b70d7>
Date: Sat, 29 Dec 2007 14:17:06 +0000
Subject: [PATCH] Before pam_end(), the return value of the previous pam API
 was already checked. No need to validate it again.

---
 ChangeLog      | 2 ++
 src/newusers.c | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e6103507..a31f9762 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,8 @@
 	newusers cleanups
 	* src/newusers.c: main() split in new functions: process_flags(),
 	check_flags(), check_perms(), open_files(), and close_files().
+	* src/newusers.c: Before pam_end(), the return value of the previous
+	pam API was already checked. No need to validate it again.
 
 2007-12-29  Nicolas François  <nicolas.francois@centraliens.net>
 
diff --git a/src/newusers.c b/src/newusers.c
index 2a30aa89..3e562bb3 100644
--- a/src/newusers.c
+++ b/src/newusers.c
@@ -695,8 +695,7 @@ int main (int argc, char **argv)
 	nscd_flush_cache ("group");
 
 #ifdef USE_PAM
-	if (retval == PAM_SUCCESS)
-		pam_end (pamh, PAM_SUCCESS);
+	pam_end (pamh, PAM_SUCCESS);
 #endif				/* USE_PAM */
 
 	exit (0);