nekral-guest
614c79defc
* libmisc/xgetXXbyYY.c, libmisc/myname.c, libmisc/getgr_nam_gid.c,
...
libmisc/salt.c, libmisc/list.c, libmisc/cleanup.c, src/login.c,
lib/getdef.h, lib/groupio.c, lib/getlong.c, lib/gshadow_.h,
lib/sgroupio.c, lib/shadowio.c, lib/pwio.c, lib/commonio.h,
lib/fputsx.c, lib/prototypes.h: Added splint annotations.
* lib/groupio.c: Avoid implicit conversion of pointers to
booleans.
* lib/groupio.c: Free allocated buffers in case of failure.
2009-04-23 09:57:03 +00:00
nekral-guest
fe29344b33
* lib/defines.h: Added splint definitions to replace <locale.h>
2009-04-22 21:22:32 +00:00
nekral-guest
2c0f3ef707
* libmisc/utmp.c, libmisc/age.c, libmisc/shell.c, lib/groupio.c,
...
lib/groupio.h, lib/sgroupio.c, lib/sgroupio.h, lib/shadowio.c,
lib/pwio.c, lib/commonio.c, lib/shadowio.h, lib/pwio.h,
lib/commonio.h, lib/prototypes.h: Added splint annotations.
2009-04-22 21:21:14 +00:00
nekral-guest
aebddca35d
* libmisc/utmp.c: Added splint annotations.
2009-04-22 21:07:33 +00:00
nekral-guest
620ee81b7e
* libmisc/utmp.c: Only set ut_time and ut_tv if gettimeofday()
...
succeeds.
2009-04-22 21:06:13 +00:00
nekral-guest
e76a5df932
* libmisc/utmp.c: Fix the check for empty host in prepare_utmp()
...
and prepare_utmpx().
2009-04-22 21:04:16 +00:00
nekral-guest
7fb1063ccd
* libmisc/utmp.c: The ut argument of prepare_utmp() might be NULL.
...
ut_id needs to be forged in that case.
2009-04-22 21:02:46 +00:00
nekral-guest
811288df64
* libmisc/utmp.c: Removed old documentation of setutmp().
2009-04-22 21:00:18 +00:00
nekral-guest
31906409c8
* libmisc/utmp.c: Use xmalloc() rather than malloc().
2009-04-22 20:59:23 +00:00
nekral-guest
b05783da32
* libmisc/utmp.c: The name returned by ttyame() needs to be copied
...
locally.
2009-04-22 20:57:29 +00:00
nekral-guest
54302f6006
* src/login.c: Added splint annotations.
2009-04-22 20:53:15 +00:00
nekral-guest
2a32262725
* src/login.c: Added assert()s for NULL (or ! NULL) username, and
...
pwd. This helps splint.
2009-04-22 20:51:13 +00:00
nekral-guest
c55311aa6d
* src/login.c: After login_prompt(), do not check for unset
...
username, but for empty username.
2009-04-22 20:46:49 +00:00
nekral-guest
3704745289
* lib/defines.h: Define USER_NAME_MAX_LENGTH, based on utmp and
...
default to 32.
* libmisc/chkname.c: Use USER_NAME_MAX_LENGTH.
* src/login.c: Use USER_NAME_MAX_LENGTH instead of the default 32.
username also needs to be bigger than USER_NAME_MAX_LENGTH because
it has to be nul-terminated.
2009-04-22 20:42:48 +00:00
nekral-guest
eae8b63d4f
* src/login.c: Use xmalloc() instead of malloc().
2009-04-22 20:21:17 +00:00
nekral-guest
349efcb0a6
* src/login.c: Ignore the return value of puts(), fputs(),
...
strftime().
2009-04-22 20:17:11 +00:00
nekral-guest
46d697cded
* src/login.c: timeout, delay, and retries should be unsigned.
...
* src/login.c: Ignore the return value of alarm() and sleep().
2009-04-22 20:15:21 +00:00
nekral-guest
53e0ff91d3
* src/login.c: If we cannot get the terminal configuration, do not
...
change the terminal configuration. setup_tty() is just a best
effort configuration of the terminal.
* src/login.c: Ignore failures when setting the terminal
configuration.
* src/login.c: Fail if the ERASECHAR or KILLCHAR configurations
are not compatible with a cc_t type.
2009-04-22 20:12:06 +00:00
nekral-guest
a362a68f53
* src/login.c: utent might be NULL after get_current_utmp().
2009-04-22 20:07:34 +00:00
nekral-guest
332a50c273
* src/login.c: Removed temp_shell. No more used.
...
* src/login.c: lastlog is only used #ifndef USE_PAM
* src/login.c: Rename lastlog to ll to avoid name clash with the
lastlog type.
2009-04-22 20:03:26 +00:00
nekral-guest
790dbb07fc
* src/login.c: Added update_utmp() to group the prepare_utmp and
...
setutmp (and the utmpx versions).
2009-04-22 19:58:39 +00:00
nekral-guest
f59a69f4b6
* src/login.c: Do not include netdb.h. gethostbyname() is no more
...
called from within login.c. Also UT_ADDR does not exist anymore.
2009-04-22 19:54:28 +00:00
nekral-guest
efcbbc3d74
* src/login.c: Check if login is run with effective root
...
privileges. This should be more helpful to users than a failure to
find an utmp entry or failure to access a file.
2009-04-21 22:46:01 +00:00
nekral-guest
a0503bc3a1
Added previous commit changelog.
2009-04-21 22:39:52 +00:00
nekral-guest
fcfa81283e
* NEWS, configure.in: Enable --enable-account-tools-setuid by
...
default for PAM builds, as it used to be before the introduction
of this option.
2009-04-21 22:22:08 +00:00
nekral-guest
fba5cad820
* etc/pam.d/Makefile.am: Distribute all pam.d files, even if
...
ACCT_TOOLS_SETUID is not enabled.
2009-04-21 22:16:17 +00:00
nekral-guest
5bdf239a66
* lib/shadowmem.c: Added spw_free().
...
* lib/shadowio.c: Use spw_free() for shadow_free().
* lib/groupmem.c: Added gr_free().
* lib/groupio.c: Use gr_free() for group_free().
* lib/pwmem.c: Include define.h before prototypes.h
* lib/pwmem.c: Added pw_free().
* lib/pwio.c: Use pw_free() for passwd_free().
* lib/sgroupio.c: Added sgr_free().
* lib/sgroupio.c: Use sgr_free() for gshadow_free().
* lib/prototypes.h: Added gr_free(), pw_free(), sgr_free(),
spw_free().
2009-04-21 22:14:10 +00:00
nekral-guest
408a30f0ba
* libmisc/shell.c: Add brackets and parenthesis.
...
* libmisc/shell.c: Avoid assignments in comparisons.
* libmisc/shell.c: Re-indent.
2009-04-21 22:07:35 +00:00
nekral-guest
c8f45eda53
* lib/defines.h: Added MIN and MAX macros.
...
* libmisc/salt.c: Removed MIN and MAX macros.
2009-04-21 22:06:09 +00:00
nekral-guest
5ad0d896f1
Added more comments to the changelog entry.
2009-04-20 14:06:06 +00:00
nekral-guest
9efd6a53d2
* NEWS, src/lastlog.c: Fix regression causing empty reports.
2009-04-20 14:04:48 +00:00
nekral-guest
18fdfee274
* src/login.c: Get rid of pwent. pwd is sufficient as long as it
...
is always coming from xgetpwnam. There is no need to copy pwd to
pwent, this was not a good idea anyway as the strings from pwd
were not duplicated.
* src/login.c: Always free the pwd and spwd structure when we
retrieve a new one. This will clear the password of the previous
user from the memory.
* src/login.c: user_passwd is used to keep point to the password
of the user being authenticated.
* src/login.c: (non PAM) Fail if the user's entry cannot be found
after the user updated her password (if expire() requested an
update).
* src/login.c: If the user does not exist on the system, there is
no need to build a pwd structure (with shell).
2009-04-20 13:29:15 +00:00
nekral-guest
a6ac4dda75
* src/login.c: ttytype already checks for TTYTYPE_FILE and TERM.
...
Just call ttytype.
2009-04-20 13:12:09 +00:00
nekral-guest
c694843da5
* src/login.c: Open the PAM session before pam_setcred and before
...
initgroups. This is more consistent with rfc86.0.
2009-04-20 12:54:17 +00:00
nekral-guest
432faba3e1
* src/login.c: Added helper functions get_pam_user() and
...
get_failent_user().
2009-04-20 12:47:04 +00:00
nekral-guest
70e1a5c9b6
* src/login.c: Added parameter to check_nologin. This will help
...
getting rid of the global pwent variable.
2009-04-20 12:33:01 +00:00
nekral-guest
61c1d100dc
* src/login.c: Added comments.
...
* src/login.c: Close the user and group files before dropping root
privileges.
2009-04-20 12:27:27 +00:00
nekral-guest
d4158bdf77
* src/login.c: We do not need to keep the old umask. Discard the
...
umask() return value.
2009-04-20 12:16:07 +00:00
nekral-guest
1bcf2ffb59
* libmisc/hushed.c, lib/prototypes.h, src/login.c: Change the
...
hushed() prototype to take a username instead of a passwd
structure in argument. The passwd entry is retrieved withing
hushed().
2009-04-20 11:48:59 +00:00
nekral-guest
87ac185752
* libmisc/setugid.c: Updated comments.
2009-04-20 11:43:36 +00:00
nekral-guest
22fbd774dc
* libmisc/failure.h, libmisc/failure.c, src/login.c: Added
...
username as first parameter of failtmp to avoid issues with
non-null terminated ut_user, unavailability of ut_user, incomplete
username (that should not happen currently).
2009-04-20 11:39:16 +00:00
nekral-guest
f3bea401e9
* libmisc/ttytype.c: Add brackets and parenthesis.
...
* libmisc/ttytype.c: Avoid assignments in comparisons.
2009-04-20 11:31:05 +00:00
nekral-guest
2ce68e8aec
* lib/pwio.c, lib/shadowio.c, lib/groupio.c, lib/sgroupio.c: Fill
...
the password fields with zeros before they are freed.
2009-04-20 11:29:17 +00:00
nekral-guest
bf66861e3f
* po/ko.po: Updated Korean translation.
2009-04-19 16:26:17 +00:00
nekral-guest
131e95ffaf
* NEWS, src/login.c: Also check if the authentication token of the
...
user has to be updated in case the user was already authenticated.
2009-04-19 16:22:17 +00:00
nekral-guest
ca10b825c7
* src/login.c: fflg is already restricted to root. Move
...
pam_acct_mgmt(), in case of fflg, earlier. This is equivalent and
simplifies the code.
2009-04-19 16:09:00 +00:00
nekral-guest
2ed05e548b
* libmisc/utmp.c: Always call endutent or endutxent when setutent
...
or setutxent were used.
2009-04-19 15:28:38 +00:00
nekral-guest
8156c3b0be
* src/login.c: Added comment to make sure PAM_RHOST or PAM_TTY do
...
not get set to unsanitized values.
2009-04-19 13:33:24 +00:00
nekral-guest
d2a822fe39
* libmisc/utmp.c: Do not trust the current utmp entry's ut_line.
...
Always set ut_line based on ttyname(0).
2009-04-17 21:25:30 +00:00
nekral-guest
5298ac3dd9
* NEWS, src/login.c: Do not trust the current utmp entry's ut_line
...
to set PAM_TTY.
2009-04-17 20:40:26 +00:00