From 22d67bcfb99b7b734ca0e696e2e1a12c0a329597 Mon Sep 17 00:00:00 2001 From: Juan RP Date: Wed, 26 Jan 2011 18:57:29 +0100 Subject: [PATCH] Improve comments for dependency sorting. --- lib/transaction_sortdeps.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/transaction_sortdeps.c b/lib/transaction_sortdeps.c index 46022c03..f321f5af 100644 --- a/lib/transaction_sortdeps.c +++ b/lib/transaction_sortdeps.c @@ -37,13 +37,16 @@ * the repository plist index file in the "unsorted_deps" array. * * When a package has no rundeps or all rundeps are satisfied, the package - * dictionary is added into the "packages" array and it is removed from the - * "unsorted_deps" array; that means the package has been sorted in the - * transaction. + * dictionary is added into the sorted "packages" array and it is marked as + * sorted in its dictionary with a boolean object. * * It will loop until all packages are processed and will check that * the number of packages added into the "packages" array is the same than * it was in the "unsorted_deps" array. + * + * Sure I could make it not iterate so many times but probably it will + * also be slower! that's why XBPS uses proplib with its red-black trees, + * iterating over them is fast. */ int HIDDEN xbps_sort_pkg_deps(void)