From b18499a62d79701965838fc3d63e1251dd6b7fb2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Nogueira?= Date: Wed, 12 May 2021 10:22:12 -0300 Subject: [PATCH] bin/xbps-query: use fwrite directly. Avoids allocations and an unnecessary loop (and printf usage, fputs would have been enough). Closes: #401 [via git-merge-pr] --- bin/xbps-query/show-info-files.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/bin/xbps-query/show-info-files.c b/bin/xbps-query/show-info-files.c index 9d681ff2..dc3b8fe4 100644 --- a/bin/xbps-query/show-info-files.c +++ b/bin/xbps-query/show-info-files.c @@ -106,17 +106,7 @@ print_value_obj(const char *keyname, xbps_object_t obj, xbps_humanize_number(size, (int64_t)xbps_data_size(obj)); printf("%s%s%s%s: %s\n", indent, bold, keyname, reset, size); } else { - FILE *f; - char buf[BUFSIZ-1]; - void *data; - - data = xbps_data_data(obj); - f = fmemopen(data, xbps_data_size(obj), "r"); - assert(f); - while (fgets(buf, sizeof(buf), f)) - printf("%s", buf); - fclose(f); - free(data); + fwrite(xbps_data_data_nocopy(obj), 1, xbps_data_size(obj), stdout); } break; default: