From cd4435749606f5ef957362bf47e4c04db927dea9 Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Sun, 14 Nov 2021 19:32:34 +0530
Subject: [PATCH 1/9] updated version

I accidentally pushed the previous commit to master instead of this
branch. This should revert things
---
 naxalnet/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index 69ce491..ca60229 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1"
+__version__ = "0.5.1a0.dev2"

From caeb0426126148f72c578a9bbcbcb321fd2d3f58 Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Sun, 14 Nov 2021 19:46:04 +0530
Subject: [PATCH 2/9] implemented NetworkLoop call in scripts.py

See any_interface_is_routable()
---
 naxalnet/__init__.py |  2 +-
 naxalnet/scripts.py  | 11 ++++-------
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index ca60229..623d2e4 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1a0.dev2"
+__version__ = "0.5.1a0.dev3"
diff --git a/naxalnet/scripts.py b/naxalnet/scripts.py
index 89dd382..4dbcd20 100644
--- a/naxalnet/scripts.py
+++ b/naxalnet/scripts.py
@@ -37,7 +37,7 @@ from naxalnet.log import logger
 from naxalnet.iwd import Adapter, Device, IWD
 from naxalnet.config import args
 from naxalnet.daemon import Daemon
-from naxalnet.network import NetworkD
+from naxalnet.network import NetworkD, NetworkLoop
 
 
 def get_sorted_glob(directory: str, glob: str) -> list:
@@ -56,17 +56,14 @@ def get_sorted_glob(directory: str, glob: str) -> list:
 
 def any_interface_is_routable():
     """returns true if any of the interfaces is routable"""
-    networkd = NetworkD(runtime_dir=args.networkd_runtime_dir)
+    networkd = NetworkLoop(runtime_dir=args.networkd_runtime_dir)
 
     # First, add the temporary configs to networkd.
     for i in get_sorted_glob(args.networkd_config_dir, TMP_NET_GLOB):
         logger.debug("Adding temporary config %s", i)
         networkd.add_config(i)
-    # Then, wait for some time to setup the network.
-    # This can probably be replaced by a d-bus wait-for-signal
-    # function that timeouts after 10 seconds.
-    time.sleep(10)
-    routable = networkd.is_routable()
+
+    routable = networkd.wait_until_routable()
     networkd.remove_all_configs()
 
     return routable

From 183ce16eca46bec56916a78ef3dc0c79cd3bb1d4 Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Sun, 14 Nov 2021 19:57:35 +0530
Subject: [PATCH 3/9] added timeout

This doesn't work yet
---
 naxalnet/__init__.py |  2 +-
 naxalnet/network.py  | 12 ++++++++++--
 naxalnet/scripts.py  |  3 ++-
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index 623d2e4..2a38d30 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1a0.dev3"
+__version__ = "0.5.1a0.dev4"
diff --git a/naxalnet/network.py b/naxalnet/network.py
index caa1e80..d1787f0 100644
--- a/naxalnet/network.py
+++ b/naxalnet/network.py
@@ -29,6 +29,7 @@ examples.
 
 import subprocess
 from pathlib import Path
+from gi.repository import GObject
 from dasbus.connection import SystemMessageBus
 from dasbus.loop import EventLoop
 
@@ -145,10 +146,12 @@ class NetworkLoop(NetworkD):
 
     def wait_until_routable(self, timeout=0):
         """
-        wait until timeout in milliseconds and returns True when any
-        network interface is shown routable by networkd
+        Wait until timeout in milliseconds and returns True when any
+        network interface is shown routable by networkd. Does not wait
+        for timeout if timeout==0
         """
         self.wait_for_change("AddressState", self.on_addressstate_change)
+        self.setup_timeout(timeout)
         return self.is_routable()
 
     def wait_for_change(self, name, function):
@@ -167,6 +170,11 @@ class NetworkLoop(NetworkD):
         if self.waitfor in data:
             return self.wait_function()
 
+    def setup_timeout(self, timeout):
+        """setup a timeout"""
+        if timeout != 0:
+            GObject.timeout_add(timeout, self.on_timeout)
+
     def on_timeout(self):
         """called by dasbus when a timeout occurs"""
         self.loop.quit()
diff --git a/naxalnet/scripts.py b/naxalnet/scripts.py
index 4dbcd20..64ec06d 100644
--- a/naxalnet/scripts.py
+++ b/naxalnet/scripts.py
@@ -63,7 +63,8 @@ def any_interface_is_routable():
         logger.debug("Adding temporary config %s", i)
         networkd.add_config(i)
 
-    routable = networkd.wait_until_routable()
+    # timeout = 10 seconds
+    routable = networkd.wait_until_routable(10 * 1000)
     networkd.remove_all_configs()
 
     return routable

From d7a84d8ccca4c4c90f2bcbf3195ea63fa72291a5 Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Tue, 16 Nov 2021 22:00:00 +0530
Subject: [PATCH 4/9] replaced GObject with GLib in network.py

See the previous commit. And the one preceding that. And the one before
that. Keep going until /dev/brain0 gets symlinked to /dev/urandom
---
 naxalnet/__init__.py |  2 +-
 naxalnet/network.py  | 19 ++++++++++++++++---
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index 2a38d30..1d5eb43 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1a0.dev4"
+__version__ = "0.5.1a0.dev5"
diff --git a/naxalnet/network.py b/naxalnet/network.py
index d1787f0..f0f6899 100644
--- a/naxalnet/network.py
+++ b/naxalnet/network.py
@@ -29,9 +29,8 @@ examples.
 
 import subprocess
 from pathlib import Path
-from gi.repository import GObject
 from dasbus.connection import SystemMessageBus
-from dasbus.loop import EventLoop
+from dasbus.loop import EventLoop, GLib
 
 
 NETWORKD_BUS = "org.freedesktop.network1"
@@ -46,6 +45,7 @@ class NetworkD:
     """
 
     def __init__(self, runtime_dir="/run/systemd/network", bus=SystemMessageBus()):
+        print("NetworkD init")
         self._bus = bus
         self.proxy_reload()
 
@@ -122,6 +122,9 @@ class NetworkD:
             self.remove_config(i.name)
 
 
+# TODO: remove all calls to print() before merging to master
+
+
 class NetworkLoop(NetworkD):
     """Used to wait until a condition is met
 
@@ -133,6 +136,7 @@ class NetworkLoop(NetworkD):
     """
 
     def __init__(self, *args, **kwargs):
+        print("NetworkLoop init")
         # first, initialise the parent object
         super().__init__(*args, **kwargs)
         self.waitfor = None
@@ -141,6 +145,9 @@ class NetworkLoop(NetworkD):
 
     def start_loop(self):
         """start the dasbus loop"""
+        print("start loop")
+        print("waitfor", self.waitfor)
+        print("waitfor func", self.wait_function)
         self.proxy.PropertiesChanged.connect(self.on_properties_changed)
         self.loop.run()
 
@@ -150,31 +157,37 @@ class NetworkLoop(NetworkD):
         network interface is shown routable by networkd. Does not wait
         for timeout if timeout==0
         """
+        print("wait until routable")
         self.wait_for_change("AddressState", self.on_addressstate_change)
         self.setup_timeout(timeout)
         return self.is_routable()
 
     def wait_for_change(self, name, function):
         """used by the public functions"""
+        print("wait for change")
         self.waitfor = name
         self.wait_function = function
         self.start_loop()
 
     def on_addressstate_change(self):
         """quit the loop if the network is routable"""
+        print("on addrstate change")
         if self.is_routable():
             self.loop.quit()
 
     def on_properties_changed(self, bus_interface, data, blah):
         """give this function some documentation"""
+        print("on properties changed")
         if self.waitfor in data:
             return self.wait_function()
 
     def setup_timeout(self, timeout):
         """setup a timeout"""
+        print("setup timeout")
         if timeout != 0:
-            GObject.timeout_add(timeout, self.on_timeout)
+            GLib.timeout_add(timeout, self.on_timeout)
 
     def on_timeout(self):
         """called by dasbus when a timeout occurs"""
+        print("on timeout")
         self.loop.quit()

From 5e58df0b711614aca67cfb5d34d245a82f7729f2 Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Mon, 29 Nov 2021 14:36:59 +0530
Subject: [PATCH 5/9] temporary fix for #25

Uses multithreading.Process instead of GLib.timeout_add()

The moment I finished writing this part, I found out the only problem
with my previous commit was that I had setup the timeout _after_ calling
the blocking function wait_for_change instead of before it.

Although this version (with Process) works, I'm reverting to the
previous version and swapping the two lines (which I had tested and
found to work)

And in case you have read upto the previous line you should also know I
fixed some code in the README

TL;DR: I have proven once again I am an idiot
---
 README.md            |  7 ++++---
 naxalnet/__init__.py |  2 +-
 naxalnet/network.py  | 31 ++++++++++++++++++++-----------
 naxalnet/scripts.py  |  3 +--
 pyproject.toml       |  1 +
 setup.cfg            |  5 ++++-
 6 files changed, 31 insertions(+), 18 deletions(-)

diff --git a/README.md b/README.md
index 0511620..59444cf 100644
--- a/README.md
+++ b/README.md
@@ -136,7 +136,7 @@ uname -r
 python3 --version
 
 # Check for IBSS (ad-hoc) support in your WiFi firmware or driver
-iw phy | grep -iq ibss && echo "IBSS is supported" || echo "IBSS not supported"
+iw phy | grep -q join_ibss && echo "IBSS is supported" || echo "IBSS not supported"
 ```
 
 Clone the naxalnet repo and cd into it.
@@ -300,8 +300,9 @@ systemd-networkd configures the network.
 
 ### Online class
 
-naxalnet can be used to share connections to join online classes.
-You need at least one device with internet access if you are not using a program like [Jami][].
+naxalnet can be used to share connections to join online classes. You need
+at least one device with internet access if you are not using a program
+like [Jami][].
 
 <!--
 
diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index 1d5eb43..8eccc68 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1a0.dev5"
+__version__ = "0.5.1a0.dev6"
diff --git a/naxalnet/network.py b/naxalnet/network.py
index f0f6899..00563d9 100644
--- a/naxalnet/network.py
+++ b/naxalnet/network.py
@@ -28,9 +28,10 @@ examples.
 """
 
 import subprocess
+from multiprocessing import Process
 from pathlib import Path
 from dasbus.connection import SystemMessageBus
-from dasbus.loop import EventLoop, GLib
+from dasbus.loop import EventLoop
 
 
 NETWORKD_BUS = "org.freedesktop.network1"
@@ -142,6 +143,7 @@ class NetworkLoop(NetworkD):
         self.waitfor = None
         self.wait_function = None
         self.loop = EventLoop()
+        self.timeout = 0
 
     def start_loop(self):
         """start the dasbus loop"""
@@ -149,17 +151,30 @@ class NetworkLoop(NetworkD):
         print("waitfor", self.waitfor)
         print("waitfor func", self.wait_function)
         self.proxy.PropertiesChanged.connect(self.on_properties_changed)
-        self.loop.run()
+        process = Process(target=self.loop.run)
+        process.start()
+
+        # wait until timeout
+        if self.timeout != 0:
+            process.join(self.timeout)
+        else:
+            process.join()
+
+        # When the process is timed out, it is not killed. We have to kill
+        # it manually
+        if process.is_alive():
+            self.on_timeout()
 
     def wait_until_routable(self, timeout=0):
         """
-        Wait until timeout in milliseconds and returns True when any
+        Wait until timeout in seconds and returns True when any
         network interface is shown routable by networkd. Does not wait
         for timeout if timeout==0
         """
         print("wait until routable")
+        self.timeout = timeout
         self.wait_for_change("AddressState", self.on_addressstate_change)
-        self.setup_timeout(timeout)
+
         return self.is_routable()
 
     def wait_for_change(self, name, function):
@@ -181,13 +196,7 @@ class NetworkLoop(NetworkD):
         if self.waitfor in data:
             return self.wait_function()
 
-    def setup_timeout(self, timeout):
-        """setup a timeout"""
-        print("setup timeout")
-        if timeout != 0:
-            GLib.timeout_add(timeout, self.on_timeout)
-
     def on_timeout(self):
-        """called by dasbus when a timeout occurs"""
+        """called when a timeout occurs"""
         print("on timeout")
         self.loop.quit()
diff --git a/naxalnet/scripts.py b/naxalnet/scripts.py
index 64ec06d..609ab53 100644
--- a/naxalnet/scripts.py
+++ b/naxalnet/scripts.py
@@ -63,8 +63,7 @@ def any_interface_is_routable():
         logger.debug("Adding temporary config %s", i)
         networkd.add_config(i)
 
-    # timeout = 10 seconds
-    routable = networkd.wait_until_routable(10 * 1000)
+    routable = networkd.wait_until_routable(timeout=10)
     networkd.remove_all_configs()
 
     return routable
diff --git a/pyproject.toml b/pyproject.toml
index 9787c3b..a12178b 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,3 +1,4 @@
 [build-system]
+# I don't know what this means, I just copied it from some setuptools tutorial
 requires = ["setuptools", "wheel"]
 build-backend = "setuptools.build_meta"
diff --git a/setup.cfg b/setup.cfg
index 10e5e2f..0f65a8f 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,4 +1,7 @@
-# This program is not meant to be distributed through PyPi
+# This file is loosely based on the setup.cfg used in django.
+# naxalnet is not meant to be distributed through PyPi. This program uses
+# a systemd service, and some other files whose path is hardcoded into the
+# module.
 [metadata]
 name = naxalnet
 version = attr: naxalnet.__version__

From fc1f3d4216e691db93684e7539002a49d40bb0ad Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Mon, 29 Nov 2021 14:47:59 +0530
Subject: [PATCH 6/9] another fix for #25

Or, to be more precise, a fix for the fix preceding the current fix for
issue #25 that just didn't fix things right. If your head spins, see the
previous commit, or call an ambulance (that is, if you are privileged
enough to access a phone and know your local helpline number)
---
 naxalnet/__init__.py |  2 +-
 naxalnet/network.py  | 30 +++++++++++-------------------
 naxalnet/scripts.py  |  5 ++++-
 3 files changed, 16 insertions(+), 21 deletions(-)

diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index 8eccc68..fc0d289 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1a0.dev6"
+__version__ = "0.5.1a0.dev7"
diff --git a/naxalnet/network.py b/naxalnet/network.py
index 00563d9..4a59616 100644
--- a/naxalnet/network.py
+++ b/naxalnet/network.py
@@ -28,10 +28,9 @@ examples.
 """
 
 import subprocess
-from multiprocessing import Process
 from pathlib import Path
 from dasbus.connection import SystemMessageBus
-from dasbus.loop import EventLoop
+from dasbus.loop import EventLoop, GLib
 
 
 NETWORKD_BUS = "org.freedesktop.network1"
@@ -143,7 +142,6 @@ class NetworkLoop(NetworkD):
         self.waitfor = None
         self.wait_function = None
         self.loop = EventLoop()
-        self.timeout = 0
 
     def start_loop(self):
         """start the dasbus loop"""
@@ -151,28 +149,16 @@ class NetworkLoop(NetworkD):
         print("waitfor", self.waitfor)
         print("waitfor func", self.wait_function)
         self.proxy.PropertiesChanged.connect(self.on_properties_changed)
-        process = Process(target=self.loop.run)
-        process.start()
-
-        # wait until timeout
-        if self.timeout != 0:
-            process.join(self.timeout)
-        else:
-            process.join()
-
-        # When the process is timed out, it is not killed. We have to kill
-        # it manually
-        if process.is_alive():
-            self.on_timeout()
+        self.loop.run()
 
     def wait_until_routable(self, timeout=0):
         """
-        Wait until timeout in seconds and returns True when any
+        Wait until timeout in milliseconds and returns True when any
         network interface is shown routable by networkd. Does not wait
         for timeout if timeout==0
         """
         print("wait until routable")
-        self.timeout = timeout
+        self.setup_timeout(timeout)
         self.wait_for_change("AddressState", self.on_addressstate_change)
 
         return self.is_routable()
@@ -196,7 +182,13 @@ class NetworkLoop(NetworkD):
         if self.waitfor in data:
             return self.wait_function()
 
+    def setup_timeout(self, timeout):
+        """setup a timeout"""
+        print("setup timeout")
+        if timeout != 0:
+            GLib.timeout_add(timeout, self.on_timeout)
+
     def on_timeout(self):
-        """called when a timeout occurs"""
+        """called by dasbus when a timeout occurs"""
         print("on timeout")
         self.loop.quit()
diff --git a/naxalnet/scripts.py b/naxalnet/scripts.py
index 609ab53..8d24c76 100644
--- a/naxalnet/scripts.py
+++ b/naxalnet/scripts.py
@@ -63,7 +63,8 @@ def any_interface_is_routable():
         logger.debug("Adding temporary config %s", i)
         networkd.add_config(i)
 
-    routable = networkd.wait_until_routable(timeout=10)
+    # timeout = 10 seconds
+    routable = networkd.wait_until_routable(10 * 1000)
     networkd.remove_all_configs()
 
     return routable
@@ -243,8 +244,10 @@ def main():
         notify("STATUS=Checking for internet")
         # If any interface is routable, set gateway mode to server
         if any_interface_is_routable():
+            logger.info("Network is routable. Setting gw_mode to server")
             gateway_mode = "server"
         else:
+            logger.info("Network is not routable. Setting gw_mode to client")
             gateway_mode = "client"
         logger.info("gateway_mode set to %s", gateway_mode)
     elif args.gateway_mode in ["server", "client", "off"]:

From 888fdf3856cce97871dc0bf41464172b4e72d15b Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Wed, 1 Dec 2021 21:27:27 +0530
Subject: [PATCH 7/9] removed all print() calls from network.py

Updated CHANGELOG.md. We (another word for 'me') can push after moving
naxalnet.service out of service/. I am told the unit file is having a
rather dull time coping with per lonely life.
---
 CHANGELOG.md         |  4 ++++
 HACKING.md           | 32 ++++++++++++++------------------
 naxalnet/__init__.py |  2 +-
 naxalnet/network.py  | 23 ++++++++---------------
 4 files changed, 27 insertions(+), 34 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2e11c9b..f400780 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [Unreleased][] - 2021-12-01
+
+- Optimised auto gateway mode selection (#25)
+
 ## [v0.5.1][] - 2021-10-22
 
 - Fixed stopping at boot when GNOME starts location service (#21)
diff --git a/HACKING.md b/HACKING.md
index a008582..b5184d3 100644
--- a/HACKING.md
+++ b/HACKING.md
@@ -2,41 +2,37 @@
 
 Everyone can [hack][] naxalnet. See below for how to hack.
 
-## Questions, answers and hate speech
+## Questions and answers
 
 Join the XMPP channel <xmpp:naxalnet@chat.disroot.org> to talk about
 anything related to this program or about mesh networks in general.
-Redirect your hate messages to `/dev/null`
 
 ## Reporting issues and suggesting ideas
 
 To report a bug or suggest an idea, create a new issue at
 <https://git.disroot.org/pranav/naxalnet/issues>
 
-While reporting a bug, you need to add the debug messages too. Run
-`journalctl -fu naxalnet` on a terminal emulator (this could take some
-time). Now on another one, type `sudo systemctl start naxalnet.service` or
-whatever caused the error. Now copy the error messages and paste it in the
-issue body along with the description.
+While reporting a bug, you can add the debug messages to provide more
+data. Run `journalctl -fu naxalnet` on a terminal emulator (this could
+take some time on some machines). Now on another one, type `sudo systemctl start naxalnet.service` or whatever caused the error. Now copy the error
+messages and paste it in the issue body along with the description.
 
 ## Improving documentation
 
-The README and HACKING.md needs to be more beginner friendly.
-See #20.
+The README and HACKING.md needs to be more beginner friendly. See #20.
 
 ## Contribute code
 
-To push to this repo, you need your username to be in the
-contributors list. Add your username to issue #8 to add you
-as a contributor. Before each commit, update the CHANGELOG.md
-and `__version__` in `naxalnet/__init__.py`
+To push to this repo, you need your username to be in the contributors
+list. Add your username to issue #8 to add you as a contributor. Before
+each commit, update the CHANGELOG.md and `__version__` in
+`naxalnet/__init__.py`
 
 ## Packaging
 
-Currently this program is only packaged for Arch Linux.
-naxalnet needs packages in GNU+Linux+systemd
-distributions such as Debian, Fedora, openSUSE,
-and nixos. If you know/like to package it in your distro,
-post a message to issue #6.
+Currently this program is only packaged for Arch Linux. naxalnet needs
+packages in GNU+Linux+systemd distributions such as Debian, Fedora,
+openSUSE, and nixos. If you know/like to package it in your distro, post a
+message to issue #6.
 
 [hack]: https://catb.org/jargon/html/H/hack.html
diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index fc0d289..2106dcf 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1a0.dev7"
+__version__ = "0.5.1a0.dev8"
diff --git a/naxalnet/network.py b/naxalnet/network.py
index 4a59616..75251ef 100644
--- a/naxalnet/network.py
+++ b/naxalnet/network.py
@@ -122,9 +122,6 @@ class NetworkD:
             self.remove_config(i.name)
 
 
-# TODO: remove all calls to print() before merging to master
-
-
 class NetworkLoop(NetworkD):
     """Used to wait until a condition is met
 
@@ -136,7 +133,6 @@ class NetworkLoop(NetworkD):
     """
 
     def __init__(self, *args, **kwargs):
-        print("NetworkLoop init")
         # first, initialise the parent object
         super().__init__(*args, **kwargs)
         self.waitfor = None
@@ -145,9 +141,6 @@ class NetworkLoop(NetworkD):
 
     def start_loop(self):
         """start the dasbus loop"""
-        print("start loop")
-        print("waitfor", self.waitfor)
-        print("waitfor func", self.wait_function)
         self.proxy.PropertiesChanged.connect(self.on_properties_changed)
         self.loop.run()
 
@@ -157,38 +150,38 @@ class NetworkLoop(NetworkD):
         network interface is shown routable by networkd. Does not wait
         for timeout if timeout==0
         """
-        print("wait until routable")
         self.setup_timeout(timeout)
         self.wait_for_change("AddressState", self.on_addressstate_change)
 
         return self.is_routable()
 
     def wait_for_change(self, name, function):
-        """used by the public functions"""
-        print("wait for change")
+        """
+        Wait until the given property is changed and stop. If setup_timeout()
+        is called before calling this function, the loop stops after the timeout
+        or after the property is changed, whichever occurs first.
+        """
         self.waitfor = name
         self.wait_function = function
         self.start_loop()
 
     def on_addressstate_change(self):
         """quit the loop if the network is routable"""
-        print("on addrstate change")
         if self.is_routable():
             self.loop.quit()
 
     def on_properties_changed(self, bus_interface, data, blah):
-        """give this function some documentation"""
-        print("on properties changed")
+        """called by dasbus everytime the configured property is changed"""
         if self.waitfor in data:
             return self.wait_function()
+        # Just to shut up pylint
+        return None
 
     def setup_timeout(self, timeout):
         """setup a timeout"""
-        print("setup timeout")
         if timeout != 0:
             GLib.timeout_add(timeout, self.on_timeout)
 
     def on_timeout(self):
         """called by dasbus when a timeout occurs"""
-        print("on timeout")
         self.loop.quit()

From 710da18af990769c19ea26ded89c86dab89317b1 Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Wed, 1 Dec 2021 21:34:40 +0530
Subject: [PATCH 8/9] moved naxalnet.service to the main directory

---
 service/naxalnet.service => naxalnet.service | 0
 setup.cfg                                    | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename service/naxalnet.service => naxalnet.service (100%)

diff --git a/service/naxalnet.service b/naxalnet.service
similarity index 100%
rename from service/naxalnet.service
rename to naxalnet.service
diff --git a/setup.cfg b/setup.cfg
index 0f65a8f..dc6a010 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -36,7 +36,7 @@ console_scripts =
 
 [options.data_files]
 lib/systemd/system =
-    service/naxalnet.service
+    naxalnet.service
 # If installing with pip, this file will be copied to some other place.
 # This is the reason we use setup.py instead of pip in the Makefile.
 /etc/naxalnet =

From 6bca6149b7e4d508735f3b4aa8b8f34705f088bd Mon Sep 17 00:00:00 2001
From: Pranav Jerry <libreinator@disroot.org>
Date: Thu, 2 Dec 2021 19:29:19 +0530
Subject: [PATCH 9/9] ready to merge

---
 naxalnet/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/naxalnet/__init__.py b/naxalnet/__init__.py
index 2106dcf..efed3cb 100644
--- a/naxalnet/__init__.py
+++ b/naxalnet/__init__.py
@@ -42,4 +42,4 @@ given below.
 #
 # In case you forgot to change the version, skip the number
 # and put the next number in the next commit.
-__version__ = "0.5.1a0.dev8"
+__version__ = "0.5.1a1"