Replace ArrayList type fields with List

src/main/java/baritone/Settings.java

@@ -310,7 +310,7 @@ public class Settings {
 
     @SuppressWarnings("unchecked")
     public <T> List<Setting<T>> getByValueType(Class<T> klass) {
-        ArrayList<Setting<T>> result = new ArrayList<>();
+        List<Setting<T>> result = new ArrayList<>();
         for (Setting<?> setting : allSettings) {
             if (setting.klass.equals(klass)) {
                 result.add((Setting<T>) setting);

src/main/java/baritone/chunk/CachedRegion.java

@@ -235,7 +235,7 @@ public final class CachedRegion implements IBlockTypeAccess {
                             short numSpecialBlockTypes = in.readShort();
                             for (int i = 0; i < numSpecialBlockTypes; i++) {
                                 String blockName = in.readUTF();
-                                ArrayList<BlockPos> locs = new ArrayList<>();
+                                List<BlockPos> locs = new ArrayList<>();
                                 location[x][z].put(blockName, locs);
                                 short numLocations = in.readShort();
                                 for (int j = 0; j < numLocations; j++) {

src/main/java/baritone/pathing/movement/movements/MovementDiagonal.java

@@ -145,7 +145,7 @@ public class MovementDiagonal extends Movement {
         if (toBreakCached != null) {
             return toBreakCached;
         }
-        ArrayList<BlockPos> result = new ArrayList<>();
+        List<BlockPos> result = new ArrayList<>();
         for (int i = 4; i < 6; i++) {
             if (!MovementHelper.canWalkThrough(positionsToBreak[i])) {
                 result.add(positionsToBreak[i]);

src/main/java/baritone/utils/ExampleBaritoneControl.java

@@ -272,7 +272,7 @@ public class ExampleBaritoneControl extends Behavior {
         }
         if (msg.toLowerCase().equals("costs")) {
             Movement[] movements = AStarPathFinder.getConnectedPositions(new BetterBlockPos(playerFeet()), new CalculationContext());
-            ArrayList<Movement> moves = new ArrayList<>(Arrays.asList(movements));
+            List<Movement> moves = new ArrayList<>(Arrays.asList(movements));
             moves.sort(Comparator.comparingDouble(movement -> movement.getCost(new CalculationContext())));
             for (Movement move : moves) {
                 String[] parts = move.getClass().toString().split("\\.");