fix inefficient schematic block lookups

This commit is contained in:
Leijurv 2019-10-06 17:32:25 -07:00
parent d1c2a0491c
commit 8f0a8b6f56
No known key found for this signature in database
GPG Key ID: 44A3EA646EADAC6A
7 changed files with 14 additions and 13 deletions

View File

@ -135,7 +135,7 @@ public class CalculationContext {
return get(x, y, z).getBlock(); return get(x, y, z).getBlock();
} }
public double costOfPlacingAt(int x, int y, int z) { public double costOfPlacingAt(int x, int y, int z, IBlockState current) {
if (!hasThrowaway) { // only true if allowPlace is true, see constructor if (!hasThrowaway) { // only true if allowPlace is true, see constructor
return COST_INF; return COST_INF;
} }
@ -149,7 +149,7 @@ public class CalculationContext {
return placeBlockCost; return placeBlockCost;
} }
public double breakCostMultiplierAt(int x, int y, int z) { public double breakCostMultiplierAt(int x, int y, int z, IBlockState current) {
if (!allowBreak) { if (!allowBreak) {
return COST_INF; return COST_INF;
} }

View File

@ -376,7 +376,7 @@ public interface MovementHelper extends ActionCosts, Helper {
if (block instanceof BlockLiquid) { if (block instanceof BlockLiquid) {
return COST_INF; return COST_INF;
} }
double mult = context.breakCostMultiplierAt(x, y, z); double mult = context.breakCostMultiplierAt(x, y, z, state);
if (mult >= COST_INF) { if (mult >= COST_INF) {
return COST_INF; return COST_INF;
} }

View File

@ -69,7 +69,7 @@ public class MovementAscend extends Movement {
IBlockState toPlace = context.get(destX, y, destZ); IBlockState toPlace = context.get(destX, y, destZ);
double additionalPlacementCost = 0; double additionalPlacementCost = 0;
if (!MovementHelper.canWalkOn(context.bsi, destX, y, destZ, toPlace)) { if (!MovementHelper.canWalkOn(context.bsi, destX, y, destZ, toPlace)) {
additionalPlacementCost = context.costOfPlacingAt(destX, y, destZ); additionalPlacementCost = context.costOfPlacingAt(destX, y, destZ, toPlace);
if (additionalPlacementCost >= COST_INF) { if (additionalPlacementCost >= COST_INF) {
return COST_INF; return COST_INF;
} }

View File

@ -147,11 +147,11 @@ public class MovementParkour extends Movement {
// time 2 pop off with that dank skynet parkour place // time 2 pop off with that dank skynet parkour place
int destX = x + 4 * xDiff; int destX = x + 4 * xDiff;
int destZ = z + 4 * zDiff; int destZ = z + 4 * zDiff;
double placeCost = context.costOfPlacingAt(destX, y - 1, destZ); IBlockState toReplace = context.get(destX, y - 1, destZ);
double placeCost = context.costOfPlacingAt(destX, y - 1, destZ, toReplace);
if (placeCost >= COST_INF) { if (placeCost >= COST_INF) {
return; return;
} }
IBlockState toReplace = context.get(destX, y - 1, destZ);
if (!MovementHelper.isReplaceable(destX, y - 1, destZ, toReplace, context.bsi)) { if (!MovementHelper.isReplaceable(destX, y - 1, destZ, toReplace, context.bsi)) {
return; return;
} }

View File

@ -57,7 +57,8 @@ public class MovementPillar extends Movement {
} }
public static double cost(CalculationContext context, int x, int y, int z) { public static double cost(CalculationContext context, int x, int y, int z) {
Block from = context.get(x, y, z).getBlock(); IBlockState fromState = context.get(x, y, z);
Block from = fromState.getBlock();
boolean ladder = from == Blocks.LADDER || from == Blocks.VINE; boolean ladder = from == Blocks.LADDER || from == Blocks.VINE;
IBlockState fromDown = context.get(x, y - 1, z); IBlockState fromDown = context.get(x, y - 1, z);
if (!ladder) { if (!ladder) {
@ -86,7 +87,7 @@ public class MovementPillar extends Movement {
double placeCost = 0; double placeCost = 0;
if (!ladder) { if (!ladder) {
// we need to place a block where we started to jump on it // we need to place a block where we started to jump on it
placeCost = context.costOfPlacingAt(x, y, z); placeCost = context.costOfPlacingAt(x, y, z, fromState);
if (placeCost >= COST_INF) { if (placeCost >= COST_INF) {
return COST_INF; return COST_INF;
} }

View File

@ -117,7 +117,7 @@ public class MovementTraverse extends Movement {
// this happens when assume walk on water is true and this is a traverse in water, which isn't allowed // this happens when assume walk on water is true and this is a traverse in water, which isn't allowed
return COST_INF; return COST_INF;
} }
double placeCost = context.costOfPlacingAt(destX, y - 1, destZ); double placeCost = context.costOfPlacingAt(destX, y - 1, destZ, destOn);
if (placeCost >= COST_INF) { if (placeCost >= COST_INF) {
return COST_INF; return COST_INF;
} }

View File

@ -791,11 +791,11 @@ public final class BuilderProcess extends BaritoneProcessHelper implements IBuil
} }
@Override @Override
public double costOfPlacingAt(int x, int y, int z) { public double costOfPlacingAt(int x, int y, int z, IBlockState current) {
if (isPossiblyProtected(x, y, z) || !worldBorder.canPlaceAt(x, z)) { // make calculation fail properly if we can't build if (isPossiblyProtected(x, y, z) || !worldBorder.canPlaceAt(x, z)) { // make calculation fail properly if we can't build
return COST_INF; return COST_INF;
} }
IBlockState sch = getSchematic(x, y, z, bsi.get0(x, y, z)); IBlockState sch = getSchematic(x, y, z, current);
if (sch != null) { if (sch != null) {
// TODO this can return true even when allowPlace is off.... is that an issue? // TODO this can return true even when allowPlace is off.... is that an issue?
if (sch.getBlock() == Blocks.AIR) { if (sch.getBlock() == Blocks.AIR) {
@ -825,11 +825,11 @@ public final class BuilderProcess extends BaritoneProcessHelper implements IBuil
} }
@Override @Override
public double breakCostMultiplierAt(int x, int y, int z) { public double breakCostMultiplierAt(int x, int y, int z, IBlockState current) {
if (!allowBreak || isPossiblyProtected(x, y, z)) { if (!allowBreak || isPossiblyProtected(x, y, z)) {
return COST_INF; return COST_INF;
} }
IBlockState sch = getSchematic(x, y, z, bsi.get0(x, y, z)); IBlockState sch = getSchematic(x, y, z, current);
if (sch != null) { if (sch != null) {
if (sch.getBlock() == Blocks.AIR) { if (sch.getBlock() == Blocks.AIR) {
// it should be air // it should be air