Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when invalid note link

Browse Source 
Fixes #012854
This commit is contained in:
SNoiraud 2023-03-18 11:42:51 +01:00 committed by Nick Hall
parent e535fcefa5
commit 4ebba02b6b
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gramps/gen/proxy/referencedbyselection.py
View File

@ -346,7 +346,7 @@ class ReferencedBySelectionProxyDb(ProxyDbBase):
for tag in note.text.get_tags(): for tag in note.text.get_tags():
if tag.name == 'Link': if tag.name == 'Link':
if tag.value.startswith("gramps://"): if tag.value.startswith("gramps://"):
obj_class, prop, value = tag.value[9:].split("/") obj_class, prop, value = tag.value[9:].split("/", 2)
if obj_class == "Media": # bug6493 if obj_class == "Media": # bug6493
obj_class = "Media" obj_class = "Media"
if prop == "handle": if prop == "handle":

4
gramps/gui/widgets/styledtexteditor.py
View File

@ -396,7 +396,7 @@ class StyledTextEditor(Gtk.TextView):
simple_access = SimpleAccess(win_obj.dbstate.db) simple_access = SimpleAccess(win_obj.dbstate.db)
url = link_tag.data url = link_tag.data
if url.startswith("gramps://"): if url.startswith("gramps://"):
obj_class, prop, value = url[9:].split("/") obj_class, prop, value = url[9:].split("/", 2)
display = simple_access.display(obj_class, prop, value) or url display = simple_access.display(obj_class, prop, value) or url
return display + ((_("\nCommand-Click to follow link") if mac() else return display + ((_("\nCommand-Click to follow link") if mac() else
_("\nCtrl-Click to follow link")) _("\nCtrl-Click to follow link"))
@ -809,7 +809,7 @@ class StyledTextEditor(Gtk.TextView):
win_obj = find_parent_with_attr(self, attr="dbstate") win_obj = find_parent_with_attr(self, attr="dbstate")
if win_obj: if win_obj:
# Edit the object: # Edit the object:
obj_class, prop, value = url[9:].split("/") obj_class, prop, value = url[9:].split("/", 2)
from ..editors import EditObject from ..editors import EditObject
EditObject(win_obj.dbstate, EditObject(win_obj.dbstate,
win_obj.uistate, win_obj.uistate,

2
gramps/plugins/lib/libhtmlbackend.py
View File

@ -300,7 +300,7 @@ class HtmlBackend(DocBackend):
""" """
if value.startswith("gramps://"): if value.startswith("gramps://"):
if self.build_link: if self.build_link:
obj_class, prop, handle = value[9:].split("/", 3) obj_class, prop, handle = value[9:].split("/", 2)
if prop in ["handle", "gramps_id"]: if prop in ["handle", "gramps_id"]:
value = self.build_link(prop, handle, obj_class) value = self.build_link(prop, handle, obj_class)
if not value: if not value: