Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use None as the foreground colour for untagged rows in list views

Browse Source 
The call to get_style_context is not required.  It also caused
problems in Windows due to excessive calls to the foreground_color
method.

Fixes #10365.
This commit is contained in:
Nick Hall 2018-01-13 17:20:16 +00:00
parent 6648ecb5ff
commit 56122b0a54
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gramps/gui/views/listview.py
View File

@ -67,7 +67,7 @@ from gramps.gen.const import GRAMPS_LOCALE as glocale
_ = glocale.translation.sgettext
from ..ddtargets import DdTargets
from ..plug.quick import create_quickreport_menu, create_web_connect_menu
from ..utils import is_right_click, rgb_to_hex
from ..utils import is_right_click
from ..widgets.interactivesearchbox import InteractiveSearchBox
#----------------------------------------------------------------
@ -278,14 +278,11 @@ class ListView(NavigationView):
def foreground_color(self, column, renderer, model, iter_, data=None):
'''
Set the foreground color of the cell renderer. We use a cell data
function because we don't want to set the color of untagged rows.
function because there is a problem returning None from a model.
'''
fg_color = model.get_value(iter_, model.color_column())
if not fg_color:
context = self.list.get_style_context()
color = context.get_color(Gtk.StateFlags.ACTIVE)
fg_color = rgb_to_hex((color.red, color.green, color.blue))
if fg_color == '':
fg_color = None
renderer.set_property('foreground', fg_color)
def set_active(self):