Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Quick search with Czech characters -> Crash

Browse Source 
Crash happen when checking for "event.string" in "treeview_keypress"
function in "gramps/gui/widgets/interactivesearchbox.py"
Note that

https://lazka.github.io/pgi-docs/Gdk-3.0/classes/EventKey.html#Gdk.EventKey
says it is deprecated and should never be used.

Gdk.keyval_to_unicode return the corresponding unicode character, or 0
if there is no corresponding character.

Fixes #9130.
This commit is contained in:
Josip 2017-05-28 23:32:20 +02:00 committed by Nick Hall
parent ea5b54598e
commit bc17245331
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gramps/gui/views/listview.py
View File

@ -907,7 +907,7 @@ class ListView(NavigationView):
self.edit(obj) self.edit(obj)
return True return True
# Custom interactive search # Custom interactive search
if event.string: if Gdk.keyval_to_unicode(event.keyval):
return self.searchbox.treeview_keypress(obj, event) return self.searchbox.treeview_keypress(obj, event)
return False return False
@ -935,7 +935,7 @@ class ListView(NavigationView):
else: else:
self.edit(obj) self.edit(obj)
return True return True
elif event.string: elif Gdk.keyval_to_unicode(event.keyval):
# Custom interactive search # Custom interactive search
return self.searchbox.treeview_keypress(obj, event) return self.searchbox.treeview_keypress(obj, event)
return False return False

2
gramps/gui/widgets/interactivesearchbox.py
View File

@ -70,7 +70,7 @@ class InteractiveSearchBox:
function handling keypresses from the treeview function handling keypresses from the treeview
for the typeahead find capabilities for the typeahead find capabilities
""" """
if not event.string: if not Gdk.keyval_to_unicode(event.keyval):
return False return False
if self._key_cancels_search(event.keyval): if self._key_cancels_search(event.keyval):
return False return False