Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

optimization suggested by Gerald to avoid append

Browse Source 
svn: r12734
This commit is contained in:
Benny Malengier 2009-06-29 20:46:00 +00:00
parent 57dc74b965
commit d97e62fa27
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/gui/views/treemodels/flatbasemodel.py
View File

@ -468,23 +468,15 @@ class FlatBaseModel(gtk.GenericTreeModel):
""" """
Return the (sort_key, handle) list of all data that can maximally Return the (sort_key, handle) list of all data that can maximally
be shown. be shown.
This list is sorted ascending (via localized string sort) This list is sorted ascending, via localized string sort. strxfrm
is used, which is apparently broken in Win ?? --> they should fix
base lib, we need strxfrm
""" """
sort_data = [] # use cursor as a context manager
with self.gen_cursor() as cursor:
with self.gen_cursor() as cursor: # use cursor as a context manager
#loop over database and store the sort field, and the handle #loop over database and store the sort field, and the handle
for key, data in cursor: return sorted( (locale.strxfrm(self.sort_func(data)), key)
## as per locale doc, use strxfrm for frequent compare. for key, data in cursor )
## apparently broken in Win --> they should fix base lib !!
#add to sort_data in such a way that bisect module can be
# used on the result later on.
sort_data.append((locale.strxfrm(self.sort_func(data)),
key))
#bisect.insort_left(sort_data,
# (locale.strxfrm(self.sort_func(data)), key))
sort_data.sort()
return sort_data
def _rebuild_search(self, ignore=None): def _rebuild_search(self, ignore=None):
""" function called when view must be build, given a search text """ function called when view must be build, given a search text