fix if statement

.github/workflows/build_bromite_dev.yaml

@@ -185,7 +185,7 @@ jobs:
         KYTHE_ROOT_DIRECTORY: /home/lg/working_dir/chromium/src
         KYTHE_OUTPUT_DIRECTORY: /home/lg/working_dir/chromium/src/out/bromite/kythe
         # compile in debug mode
-        TARGET_ISDEBUG: true 
+        TARGET_ISDEBUG: ${{ github.event.inputs.debug }} 
         TARGET_CPU: ${{ github.event.inputs.build }}
       volumes:
         - /storage/images/${{ github.event.inputs.build }}/${{ github.event.inputs.sha }}:/home/lg/working_dir/chromium/src/out/bromite
@@ -342,8 +342,6 @@ jobs:
 #          PATH=$WORKSPACE/chromium/src/third_party/llvm-build/Release+Asserts/bin:$WORKSPACE/depot_tools/:/usr/local/go/bin:$WORKSPACE/mtool/bin:$PATH
 #          cd $WORKSPACE/chromium/src
 #          
-#          $WORKSPACE/ninja/ninja -C $WORKSPACE/chromium/src/out/bromite -a chrome_public_apk \
-#            -t compdb cc cxx objc objcxx >$WORKSPACE/chromium/src/out/bromite/compile_commands.json
 #          gn desc out/bromite 'chrome_public_apk' --format=json >out/bromite/gn_targets.json
 #          
 #          #python tools/clang/scripts/run_tool.py --tool translation_unit -p out/bromite/ --all || true
@@ -360,11 +358,15 @@ jobs:
 #            --out_dir src/out/bromite || true
 
       - name: Generate clangd index
+        if: ${{ github.event.inputs.debug == 'true' }}
         shell: bash
         run: |
           PATH=$WORKSPACE/chromium/src/third_party/llvm-build/Release+Asserts/bin:$WORKSPACE/depot_tools/:/usr/local/go/bin:$WORKSPACE/mtool/bin:$PATH
           cd $WORKSPACE/chromium/src
           
+          $WORKSPACE/ninja/ninja -C $WORKSPACE/chromium/src/out/bromite -a chrome_public_apk \
+            -t compdb cc cxx objc objcxx >$WORKSPACE/chromium/src/out/bromite/compile_commands.json
+
           test -f out/bromite/bromite.idx || \
             /home/lg/working_dir/clangd_snapshot_20211205/bin/clangd-indexer --executor=all-TUs out/bromite/compile_commands.json >out/bromite/bromite.idx
           

.github/workflows/release.yaml

@@ -1,7 +1,6 @@
 name: Release Bromite CI
-#permissions:
+permissions:
-#  contents: write
+  contents: write
-#  repo: write
       
 on:
   workflow_dispatch:
@@ -74,7 +73,7 @@ jobs:
           
           cd bromite
           VERSION=v$(cat ${{ env.OUTPUTFILE }}/RELEASE)-${{ github.event.inputs.build }}
-          ../gh_2.4.0_linux_amd64/bin/gh release create $VERSION \
+          ../gh_2.4.0_linux_amd64/bin/gh release create $VERSION-$BROMITE_SHA \
             ../$APK --notes ""
 
 #      - name: Enable proxy on container

images/bromite-build/build_args.gni

@@ -16,7 +16,7 @@ if(getenv("TARGET_CPU") != "") {
 enable_kythe_annotations = true
 clang_use_chrome_plugins = false
 
-if(!(_is_debug_build == "")) {
+if(_is_debug_build == "true") {
 # print("Debug build on")
   is_debug = true
   is_official_build = false

images/remote-index/generate.sh

@@ -13,7 +13,7 @@ fi
 sudo docker -H $DOCKER_SOCK cp $DEV_CONTAINER:/home/lg/working_dir/chromium/src/out/bromite/bromite.idx .
 sudo docker -H $DOCKER_SOCK cp $DEV_CONTAINER:/home/lg/working_dir/bromite/build/RELEASE .
 
-INDEX_VERSION=$(cat RELEASE)
+#INDEX_VERSION=$(cat RELEASE)
 DOCKER_BUILDKIT=1 docker build -t uazo/bromite-remote-index:$INDEX_VERSION \
                 --progress plain \
                 --no-cache \