midou/citra-shitamoto-network
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cecd: Fixup GetCecInfoBuffer params order (#7361)

Browse Source 
While I was looking at the NEWS sysmodule, I noticed the params order
for this command were backwards: the info type is the first param,
followed by the buffer size.

This is accurate to my reverse engineered code for the NEWS sysmodule.
This commit is contained in:
Daniel López Guimaraes 2024-01-17 07:48:42 +01:00 committed by GitHub
parent 6a7841d4b0
commit c59ef7d793
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/hle/service/cecd/cecd.cpp
View File

@ -682,16 +682,16 @@ void Module::Interface::Stop(Kernel::HLERequestContext& ctx) {
void Module::Interface::GetCecInfoBuffer(Kernel::HLERequestContext& ctx) { void Module::Interface::GetCecInfoBuffer(Kernel::HLERequestContext& ctx) {
IPC::RequestParser rp(ctx); IPC::RequestParser rp(ctx);
const u32 buffer_size = rp.Pop<u32>();
const u32 possible_info_type = rp.Pop<u32>(); const u32 possible_info_type = rp.Pop<u32>();
const u32 buffer_size = rp.Pop<u32>();
auto& buffer = rp.PopMappedBuffer(); auto& buffer = rp.PopMappedBuffer();
IPC::RequestBuilder rb = rp.MakeBuilder(1, 2); IPC::RequestBuilder rb = rp.MakeBuilder(1, 2);
rb.Push(ResultSuccess); rb.Push(ResultSuccess);
rb.PushMappedBuffer(buffer); rb.PushMappedBuffer(buffer);
LOG_DEBUG(Service_CECD, "called, buffer_size={}, possible_info_type={}", buffer_size, LOG_DEBUG(Service_CECD, "called, possible_info_type={}, buffer_size={}", possible_info_type,
possible_info_type); buffer_size);
} }
void Module::Interface::GetCecdState(Kernel::HLERequestContext& ctx) { void Module::Interface::GetCecdState(Kernel::HLERequestContext& ctx) {