midou/citra-shitamoto-network
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Common: Remove redundant masking in BitField

Browse Source 
For the signed case, the shifts already remove the rest of the value, so
ANDing by the mask is redundant.
This commit is contained in:
Yuri Kunde Schlesner 2015-07-10 18:02:56 -03:00
parent d7f9529bdd
commit d5b5280501
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/bit_field.h
View File

@ -160,7 +160,7 @@ public:
if (std::numeric_limits<T>::is_signed) if (std::numeric_limits<T>::is_signed)
{ {
std::size_t shift = 8 * sizeof(T)-bits; std::size_t shift = 8 * sizeof(T)-bits;
return (T)(((storage & GetMask()) << (shift - position)) >> shift); return (T)((storage << (shift - position)) >> shift);
} }
else else
{ {