midou/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

game_list: Use QJsonValueRef() within LoadCompatibilityList()

Browse Source 
This way, we aren't constructing unnecessary QJsonValue instances.
This commit is contained in:
Lioncash 2018-09-11 22:28:28 -04:00 committed by fearlessTobi
parent 2ba62ec196
commit 52f12e303a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/citra_qt/game_list.cpp
View File

@ -545,7 +545,7 @@ void GameList::LoadCompatibilityList() {
QJsonDocument json = QJsonDocument::fromJson(string_content.toUtf8()); QJsonDocument json = QJsonDocument::fromJson(string_content.toUtf8());
QJsonArray arr = json.array(); QJsonArray arr = json.array();
for (const QJsonValue& value : arr) { for (const QJsonValueRef& value : arr) {
QJsonObject game = value.toObject(); QJsonObject game = value.toObject();
if (game.contains("compatibility") && game["compatibility"].isDouble()) { if (game.contains("compatibility") && game["compatibility"].isDouble()) {
@ -553,7 +553,7 @@ void GameList::LoadCompatibilityList() {
QString directory = game["directory"].toString(); QString directory = game["directory"].toString();
QJsonArray ids = game["releases"].toArray(); QJsonArray ids = game["releases"].toArray();
for (const QJsonValue& value : ids) { for (const QJsonValueRef& value : ids) {
QJsonObject object = value.toObject(); QJsonObject object = value.toObject();
QString id = object["id"].toString(); QString id = object["id"].toString();
compatibility_list.emplace( compatibility_list.emplace(