midou/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

svc: Correct vma_map boundary check within QueryProcessMemory

Browse Source 
This should be using the process instance retrieved within the function,
and not g_current_process, otherwise this is potentially comparing
iterators from unrelated vma_map instances (which is undefined
behavior).
This commit is contained in:
Lioncash 2018-10-21 22:00:06 -04:00
parent 57ce5079bc
commit 930abb4b5e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/hle/kernel/svc.cpp
View File

@ -923,7 +923,7 @@ static ResultCode QueryProcessMemory(MemoryInfo* memory_info, PageInfo* page_inf
auto vma = process->vm_manager.FindVMA(addr); auto vma = process->vm_manager.FindVMA(addr);
if (vma == g_current_process->vm_manager.vma_map.end()) if (vma == process->vm_manager.vma_map.end())
return ERR_INVALID_ADDRESS; return ERR_INVALID_ADDRESS;
memory_info->base_address = vma->second.base; memory_info->base_address = vma->second.base;