midou/invidious
1
0
Fork 1
mirror of https://github.com/iv-org/invidious.git synced 2024-12-23 00:29:53 +05:30
Code Issues Packages Projects Releases Wiki Activity
3,621 Commits 7 Branches 29 Tags 55 MiB
b4ea1ccc23
Commit Graph

2291 Commits

Author SHA1 Message Date
Samantaz Fox
a6c9b263da
DB: don't pass PG_DB to check_table/check_enum 2022-01-25 23:53:00 +01:00
Samantaz Fox
5ad2fc64b4
DB: Move a forgotten 'UPDATE channels' statement 2022-01-25 23:42:36 +01:00
Samantaz Fox
2ae074a9a4
Merge pull request #2821 from matthewmcgarvey/channel-search 
Handle invalid channel id in channel: search
 2022-01-25 19:34:43 +01:00
Matthew McGarvey
c5967ad572
will -> should 
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
 2022-01-25 11:35:19 -06:00
matthewmcgarvey
574e35a720 HTML escape user input 2022-01-19 09:01:13 -06:00
Samantaz Fox
32ae38b933
Merge pull request #2822 from matthewmcgarvey/reddit-comments 
Fix loading reddit comments when there are no threads found
 2022-01-19 12:53:20 +01:00
matthewmcgarvey
56e505164d 404 error with message and provide example 2022-01-18 18:56:26 -06:00
matthewmcgarvey
d4f3139b73 Don't catch and provide better error message instead 2022-01-18 18:37:16 -06:00
matthewmcgarvey
97dceb3a5a Custom error on channel search, handle in search 2022-01-18 18:37:16 -06:00
matthewmcgarvey
212f6d6bf5 Fix channel search json parse to not raise 2022-01-18 18:37:16 -06:00
Samantaz Fox
8c2495a399
Apply suggestions from review 2022-01-17 21:47:29 +01:00
matthewmcgarvey
9233f71549 Use &.methods where possible instead of curly braces 2022-01-17 13:03:36 -06:00
matthewmcgarvey
b2a738cf13 Fix loading reddit comments when there are no threads found 2022-01-17 12:11:47 -06:00
Samantaz Fox
34a79c5f1e
Don't show "next steps" message with a stack trace 
Usually, next steps are after the error message.
Here, we want the same options to be right above the stack trace,
so users are less likely to report duplicates.
 2022-01-16 16:15:23 +01:00
Samantaz Fox
a2600acfa9
Improve crash page messages 
* Ask to read the FAQ and search for existing issues on Github
* Include links to FAQ and directly to a new github issue
* Github issue title is automatically based on exception name
* Improved HTML
* Minor languages changes
 2022-01-16 16:15:23 +01:00
Samantaz Fox
250a9191cb
Merge pull request #2814 from SamantazFox/fix-search-autofocus 
Fix search autofocus
 2022-01-16 15:24:27 +01:00
Samantaz Fox
6fab5d0554
Merge pull request #2545 from bbielsa/csv-subscriptions-import 
Add CSV Subscriptions Import
 2022-01-16 15:11:37 +01:00
Samantaz Fox
6cf6c56dd1
Autofocus search bar only on search homepage 2022-01-13 22:19:19 +01:00
Samantaz Fox
8b72481b8c
Fix comments 
"ReplyCount" is actually an Int, not a String.
 2022-01-13 20:43:46 +01:00
Samantaz Fox
aa0724f204
Merge pull request #2646 from SamantazFox/support-plurals-in-locales 
Better support of plurals in locales
 2022-01-13 12:55:55 +01:00
Samantaz Fox
eff8b23f57
Improve youtube import type detection 
Code courtesy of bbielsa:
https://gist.github.com/bbielsa/7d131aa2188945f591a8379ec0defc9b
 2022-01-12 18:13:15 +01:00
Samantaz Fox
81a2300af8
Prevent import of insanely large files 2022-01-12 01:28:58 +01:00
Samantaz Fox
fb673639f9
Merge pull request #2787 from matthewmcgarvey/related-channels 
Update to fetch related channels again
 2022-01-11 01:50:48 +01:00
matthewmcgarvey
dc62b6ffdb Can fetch related channels using just the channel ucid] 2022-01-10 17:07:52 -06:00
Samantaz Fox
eb7e79fdf7
i18n: Apply code review suggestions + code cleaning 2022-01-10 22:49:07 +01:00
Samantaz Fox
37c953e633
i18n: Use plurals for tokens/replies/unseen notifications 2022-01-10 22:49:07 +01:00
Samantaz Fox
5bb2cb7d71
i18n: Use plurals for video/view/subscriber/subscription counts 2022-01-10 22:49:07 +01:00
Samantaz Fox
692f4e5be2
i18n: Use plurals for year/month/day/etc... 2022-01-10 22:49:07 +01:00
Samantaz Fox
7bb1471207
i18n: Add dedicated function for counts translation 2022-01-10 22:49:07 +01:00
Samantaz Fox
4752e16ad2
i18n: make multiple fixes to i18next plurals 2022-01-10 22:49:07 +01:00
Samantaz Fox
67d2635e41
i18n: Add i18next plural rules and selector 2022-01-10 22:26:45 +01:00
Samantaz Fox
71a1ad307c
i18n: Add i18next plural resolver class 2022-01-10 22:26:45 +01:00
Samantaz Fox
9a48fd81a3
i18n: Add i18next plurals base sets 2022-01-10 22:26:45 +01:00
Samantaz Fox
790b7afcca
Fix indefinitely growing database 2022-01-09 22:04:10 +01:00
matthewmcgarvey
4962c00ba8 Update to fetch related channels again 2022-01-08 12:31:16 -06:00
bbielsa
6764185543
Add explicit return keyword 2022-01-08 18:07:07 +01:00
bbielsa
0a66a68db8
Move require statement to the correct file 2022-01-08 18:07:07 +01:00
bbielsa
8d47ec714e
Add text/xml as a possible mime type for xml file uploads 2022-01-08 18:07:07 +01:00
bbielsa
9607fe03af
Detect the type of subscription import format based on the content type of the file uploaded 2022-01-08 18:07:06 +01:00
bbielsa
62057e676a
Move parse_subscription_export_csv function to user/imports.cr 2022-01-08 18:07:06 +01:00
bbielsa
43ff3be751
Test if body content is likely JSON, if so parse the json format of subscriptions export. If the content is anything else, assume it is CSV and parse 2022-01-08 18:07:06 +01:00
bbielsa
7cbd79fee5
Add helper function parse_subscription_export_csv() which parses the csv format returned by the subscription exporter 2022-01-08 18:07:06 +01:00
Samantaz Fox
5a728243a2
Merge pull request #2767 from SamantazFox/fix-subscriptions-not-cleared 
Fix subscription not being cleared
 2022-01-06 14:17:33 +01:00
matthewmcgarvey
2eb7c5c037 PR feedback 2022-01-05 20:15:42 -06:00
matthewmcgarvey
ba0bc72d0b delete_by_playlist_id -> delete_by_playlist 2022-01-05 19:03:32 -06:00
matthewmcgarvey
e1219cbdef Fix playlist deletion 2022-01-05 18:24:04 -06:00
Samantaz Fox
bf0a48847c
DB: fix subscription not being cleared 
Fixes https://github.com/iv-org/invidious/issues/2764
 2022-01-05 19:58:24 +01:00
Samantaz Fox
3bb7fbb2f1
Merge pull request #2719 from SamantazFox/batch-minor-fixes 
Multiple minor fixes
 2022-01-05 17:20:57 +01:00
TheFrenchGhosty
326a362eb8
Merge pull request #2685 from SamantazFox/database-improvments 
Database improvements
 2022-01-05 09:40:39 +00:00
TheFrenchGhosty
fdc380e7f7
Merge pull request #2677 from SamantazFox/decompression-fix-2 
Temporarily fix for #2612 (round 2)
 2022-01-05 09:38:53 +00:00
Samantaz Fox
444b1c99d0
Show unavailable videos in playlists 2022-01-05 03:32:54 +01:00
Samantaz Fox
3b1a286290
Use dig?() for playlist title 2022-01-05 03:32:54 +01:00
Samantaz Fox
6c8a5a1e7f
Fix leading spaces being collapsed in descriptions 
Fixes #1954
 2022-01-05 03:32:54 +01:00
Samantaz Fox
1769b0fdce
Fix "video can't be added to playlist without JS" 
Fixes #2686
 2022-01-05 03:32:54 +01:00
Samantaz Fox
68cbc11810
Fix the search box 
Fix #277 : autoselect search field
Fix #1107: no spell checking/auto-correct on search field
 2022-01-05 03:32:44 +01:00
Samantaz Fox
302fecbdcb
Clean useless database arguments (5/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox
d74873fed1
Clean useless database arguments (4/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox
40ed4a0506
Clean useless database arguments (3/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox
c25d664edc
Clean useless database arguments (2/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox
9bad7e2940
Clean useless database arguments (1/5) 2022-01-04 17:15:43 +01:00
Samantaz Fox
6704ce3214
Move DB utility functions to the proper module 2022-01-04 17:15:43 +01:00
Samantaz Fox
914cfbd953
Move DB queries related to 'annotations' in a separate module 2022-01-04 17:15:43 +01:00
Samantaz Fox
85cf27119c
Move DB queries related to playlists in a separate module (3/3) 2022-01-04 17:15:43 +01:00
Samantaz Fox
7691f53520
Move DB queries related to 'users' in a separate module (2/2) 2022-01-04 17:15:43 +01:00
Samantaz Fox
094f835642
Move DB queries related to 'users' in a separate module (1/2) 2022-01-04 17:13:52 +01:00
Samantaz Fox
92eea3b18b
Move DB queries related to session tokens in a separate module 2022-01-04 17:13:52 +01:00
Samantaz Fox
c021b93b5c
Move DB queries related to channels in a separate module 2022-01-04 17:13:52 +01:00
Samantaz Fox
d94d4c2045
Move DB queries related to statistics in a separate module 2022-01-04 17:13:52 +01:00
Samantaz Fox
46d08237c6
Move DB queries related to playlists in a separate module (2/3) 2022-01-04 17:13:52 +01:00
Samantaz Fox
3deafe9f8d
Move DB queries related to playlists in a separate module (1/3) 2022-01-04 17:13:51 +01:00
Samantaz Fox
998edba6f0
Move DB queries related to 'videos' in a separate module 2022-01-04 17:13:51 +01:00
Samantaz Fox
a779cdd463
Merge pull request #2727 from SamantazFox/add-shorts-support 
Add support for shorts
 2021-12-28 22:13:36 +01:00
Samantaz Fox
fc2b9031d4
i18n: Add Serbian back 2021-12-22 00:52:08 +01:00
Samantaz Fox
28a6589a1e
Merge pull request #2538 from bbielsa/player-remember-position 
Retain video time position in video player
 2021-12-21 22:05:43 +01:00
Samantaz Fox
ddb06b0cac
Fix XSS vulnerability in channel playlists 
The channel/<ucid>/playlists page was vulnerable to Cross Site Scripting
(XSS), because the different URL parameters were inserted as-is in the URL
meant for instance switching.

This vulnerability could allow an attacker to inject malicious Javascript
in the page by tricking the user to click on a crafted link.

Bug introduced in commit 66e7285108
("Only use /redirect when automatically redirecting").

Thanks to Jack (@testa:cthd.icu on Matrix, @cysea on github) for responsibly
reporting this issue!
 2021-12-19 20:51:44 +01:00
Samantaz Fox
f54e247eb4
Extractors: Add support for shorts 
Fixes #2708
 2021-12-17 16:47:41 +01:00
bbielsa
b90bceb2dc Fix formatting of preferences.cr and videos.cr 2021-12-15 19:38:58 +01:00
bbielsa
f31bd5ffb9 Use localization for save player position label in the preferences page 2021-12-15 19:38:56 +01:00
bbielsa
5abe7fe123 Rename 'remember_position' to 'save_player_pos' for clarity 2021-12-15 19:37:55 +01:00
bbielsa
a6a0bbf398 Add remember_position field to the Preferences and VideoPreferences structs, and add a checkbox in the preferences page to toggle it 2021-12-15 19:37:55 +01:00
Samantaz Fox
ee91effb7a
Merge pull request #2576 from SamantazFox/fix-locales-handling 
Fix locales handling
 2021-12-12 22:26:22 +01:00
Samantaz Fox
f236a6872b
Merge pull request #2659 from SamantazFox/fix-likes-dislikes 
Fix likes/dislikes
 2021-12-06 03:52:38 +01:00
Samantaz Fox
3e0096f360
Merge pull request #2683 from iv-org/SamantazFox-patch-1 
Fix #2682
 2021-12-02 15:35:00 +01:00
Samantaz Fox
438b334320
Merge pull request #2671 from matthewmcgarvey/code-removal 
Remove dead code
 2021-12-01 20:49:23 +01:00
Samantaz Fox
4aa96ecab9
Use 'dig()' in 'find()' statements 2021-12-01 17:32:10 +01:00
Samantaz Fox
7b9d26d688
Fix #2670 
Fixes "Download widget replaces spaces in filename with +"
https://github.com/iv-org/invidious/issues/2670
 2021-11-29 23:12:55 +01:00
matthewmcgarvey
8d4b4cd14c Remove dead code 2021-11-29 09:11:50 -06:00
Samantaz Fox
342fc202a7
Fix #2682 
Fix "Missing param name: "q" (KeyError)"
https://github.com/iv-org/invidious/issues/2682
 2021-11-29 14:53:27 +01:00
Samantaz Fox
4436359d07
Use dig to get category contents 
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
 2021-11-28 23:44:37 +01:00
Samantaz Fox
91f8395222
Typo: missing '?' when looking for key in dislikes_button 
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
 2021-11-28 23:37:27 +01:00
Samantaz Fox
de00e86cd5
Decompress the response body ourselves 
Temp fix for #2612
 2021-11-28 18:04:12 +01:00
Émilien Devos
c6e086c6ff
Revert "Temporarily fix for #2612" (#2673) 2021-11-28 09:41:16 +01:00
Samantaz Fox
82f3eda82b
Merge pull request #2656 from SamantazFox/fix-2549 
extract_video_info: Make sure that the Android player response is valid
 2021-11-28 02:38:29 +01:00
Samantaz Fox
05f9613e14
Merge pull request #2623 from SamantazFox/temp-decompression-fix 
Temporarily fix for #2612
 2021-11-28 02:35:39 +01:00
Samantaz Fox
ceb1feb350
likes/dislikes: better fallback management 
'.to_i64?' instead of '.to_i64' returns nil rather than raising
an exception when it's done on an empty string.

In some rare cases, rating can be equal to 5. In this case, the
value of player_response[videoDetails][averageRating] is an
Int and not a Float.
 2021-11-25 23:16:50 +01:00
Samantaz Fox
2ea0590b03
i18n: return 'key' if 'key' is not in locales files 2021-11-25 19:46:34 +01:00
Samantaz Fox
80a513baa5
Use new techniques to get (dis)likes back 2021-11-24 01:22:09 +01:00
Samantaz Fox
ba48f68fc3
allow multiple, successive content-encodings 2021-11-21 18:16:05 +01:00
Samantaz Fox
319587e2f1
extract_video_info: make sure that the Android player response is valid 2021-11-21 17:34:17 +01:00
Samantaz Fox
bf7952d9c7
i18n: log a warning instead of rising an exception 
This is more user-friendly.
TODO: maybe make a compile time flag for testing purposes
 2021-11-21 01:54:54 +01:00
Samantaz Fox
f29ab53aff
Add other missing translations 
* on watch page and video cards (search results, playlists, etc...)
* on /feed/playlists
* in search filters (not normalized in order to avoid collisions with
an existing PR that reworks the search filters)
 2021-11-21 01:54:46 +01:00
Samantaz Fox
b5b0c58de7
Add missing translation for quality selectors 2021-11-21 01:50:11 +01:00
Samantaz Fox
a1bb421eec
Remove useless 'hl' parameters on captions URL 2021-11-21 01:50:11 +01:00
Samantaz Fox
139786b9ef
i18n: pass only the ISO code string to 'translate()' 
Don't use the whole Hash everywhere.
Also fall back nicely to english string if no translation exists.
 2021-11-21 01:50:11 +01:00
Samantaz Fox
301444563b
i18n: Use language full name instead of ISO code 
Fixes #851
 2021-11-21 01:50:11 +01:00
Samantaz Fox
9966c21c6b
i18n: Add list of language names 2021-11-21 01:50:11 +01:00
babababag
fd54cf2d05
Escape video description 2021-11-17 12:04:30 +00:00
Samantaz Fox
2c447a42f2
Make sure to only apply fix if QUIC is disabled 2021-11-16 21:40:35 +01:00
Samantaz Fox
dad8f9a0ce
Fix typo 
Should be checking the returned headers, not the sent ones.
 2021-11-16 20:39:26 +01:00
Samantaz Fox
2eac23a0b3
Temporary fix for #2612 
Don't rely on the auto compression/decompression provided by the crystal stdlib.
 2021-11-16 13:46:28 +01:00
Samantaz Fox
00904ae3f2
Merge pull request #2444 from syeopite/only-use-redirect-endpoint-when-needed 
Only use the /redirect endpoint when automatically redirecting to another instance
 2021-11-13 20:40:09 +01:00
Émilien Devos
d214a0b333
remove duplicate lsquic requirement 2021-11-12 23:02:43 +00:00
syeopite
a120f143d7
Disable quic by default 
See #2577
 2021-11-12 04:03:23 -08:00
syeopite
65fbdbff6a
Remove of gzip header w/ use_quic config 
Continuation of b0f127d4d8
 2021-11-12 03:52:50 -08:00
syeopite
6ec4dcfafd
Fix handling for maxres thumbnail 2021-11-12 03:47:58 -08:00
syeopite
48191aca6e
Fix copy-paste error 2021-11-12 03:47:57 -08:00
syeopite
83556bace2
Allow thumbnail queries with QUIC disabled 2021-11-12 03:47:57 -08:00
syeopite
814c9e6c3a
Use https for storyboard image requests 2021-11-12 03:47:57 -08:00
syeopite
547abe17d9
Use https for ggpht requests 2021-11-12 03:47:57 -08:00
syeopite
6b8450558d
Allow storyboard queries with QUIC disabled 2021-11-12 03:47:57 -08:00
syeopite
c3747c2d49
Allow ggpht queries with QUIC disabled 2021-11-12 03:47:57 -08:00
syeopite
245122104a
Respect use_quic param and fix typos 2021-11-12 03:47:57 -08:00
syeopite
b0f127d4d8
Fix gzip decompression with HTTP::Client 2021-11-12 03:47:57 -08:00
syeopite
d379a36c0e
Add compile-time flag to remove code for QUIC 2021-11-12 03:47:50 -08:00
Samantaz Fox
6cf0ff6b49
Remove useless auto_generated param from PlaylistVideo#to_xml 
given the variables available in this function's context, 'author' and 'ucid'
provide the same data 'self.author' and 'self.ucid', respectively.

Given that fact, the variable `auto_generated` has no impact on the logic of
this function, and hence can be safely removed. this greatly simplifies the
code and makes it perfectly compatible with crystal's calling convention for
'#to_xml' methods.
 2021-10-29 16:26:42 +02:00
Samantaz Fox
86f75758a7
Fix 'to_json' in struct PlaylistVideo 2021-10-29 16:26:42 +02:00
Samantaz Fox
0ec94405ce
Add TODO comments to other places 2021-10-29 16:26:42 +02:00
Samantaz Fox
33780f1995
Also fix 'to_json' in struct Video 2021-10-29 16:26:35 +02:00
Samantaz Fox
1cb715ac9f
serialized_yt_data: force datatype of 'locale' 2021-10-28 17:48:08 +02:00
Samantaz Fox
f65b628bf3
serialized_yt_data: Remove default nil value in to_json 
this will ensure that two parameters are passed and that it
doesn't collide with 'to_json(builder)'
 2021-10-28 17:48:07 +02:00
Samantaz Fox
60fa552469
Fix an infinite recursion caused by #2228 
Changes in the aforementioned PR lead to change the behavior
of some old code.

The data type of the parameters aren't explicit enough, which
makes the compiler use the wrong method because of type infering.
 2021-10-28 17:48:07 +02:00
syeopite
437bdedb07
Use env.request.resource for instance switch link 2021-10-26 16:12:25 -07:00
syeopite
a531f4f057
Rebase error 2021-10-26 16:12:25 -07:00
syeopite
bb396a310e
Remove unneeded redirect.invidious.io code in /redirect 2021-10-26 16:12:25 -07:00
syeopite
66e7285108
Only use /redirect when automatically redirecting 2021-10-26 16:12:16 -07:00
Samantaz Fox
2b81a82620
Merge pull request #2529 from DmitrySandalov/master 
Feature Request: Localization for trending iv-org#331
 2021-10-26 23:49:56 +02:00
Samantaz Fox
b555df8377
Merge pull request #2428 from syeopite/ameba-fixes 
Fix (some) issues detected by Ameba
 2021-10-26 23:34:18 +02:00
Samantaz Fox
232730e909
Merge branch 'master' into master 2021-10-26 23:31:48 +02:00
Samantaz Fox
1e0712625a
Normalize translation key for preferences categories 
categories normalized:
 - Miscellanous
 - Player
 - Visual
 - Administrator
 - Data
 - Subscription
 2021-10-26 23:17:04 +02:00
Samantaz Fox
88752f32bd
Normalize translation key for user prefrerences 
preferences normalized:
 - annotations
 - annotations_subscribed
 - automatic_instance_redirect
 - autoplay
 - captions
 - comments
 - continue
 - continue_autoplay
 - dark_mode
 - default_home
 - extend_desc
 - feed_menu
 - listen
 - local
 - locale
 - max_results
 - notifications_only
 - player_style
 - quality
 - quality_dash
 - related_videos
 - show_nick
 - sort
 - speed
 - thin_mode
 - unseen_only
 - video_loop
 - volume
 - vr_mode
 2021-10-26 23:15:39 +02:00
syeopite
e2bbc9a6fa
Switch to #sort_by! in pull_popular_videos job 2021-10-25 01:14:14 -07:00
syeopite
17e481c107
Reduce block verbosity further 2021-10-25 01:14:14 -07:00
syeopite
b8f27a42a7
Optimize assigning of on_response_received_endpoints 2021-10-25 01:14:14 -07:00
syeopite
575c66efd3
Remove extra dot between [] from ambea copy-pasting. 2021-10-25 01:14:14 -07:00
syeopite
88ad7c8d8d
Update src/invidious/routes/playlists.cr 
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
 2021-10-25 01:14:09 -07:00
syeopite
1adcac175e
Update src/invidious/routes/channels.cr 
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
 2021-10-25 01:14:09 -07:00
syeopite
dd8c412abc
Fix Style/IsAFilter issues 2021-10-25 01:14:08 -07:00
syeopite
e969c1490a
Fix Performance/ChainedCallWithNoBang issues 2021-10-25 01:12:26 -07:00
syeopite
e91421253e
Fix Style/VerboseBlock issues 2021-10-25 01:12:26 -07:00
syeopite
35d15c7c2b
Fix Style/VariableNames issues 2021-10-25 01:12:26 -07:00