0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove unused code

Browse Source
This commit is contained in:
Sefa Eyeoglu 2022-04-14 16:50:04 +02:00
parent 89125fde22
commit 14a0e85862
No known key found for this signature in database
GPG Key ID: C10411294912A422
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
launcher/minecraft/ComponentUpdateTask.cpp
View File

@ -2,6 +2,7 @@
#include "PackProfile_p.h" #include "PackProfile_p.h"
#include "PackProfile.h" #include "PackProfile.h"
#include "Component.h"
#include "meta/Index.h" #include "meta/Index.h"
#include "meta/VersionList.h" #include "meta/VersionList.h"
#include "meta/Version.h" #include "meta/Version.h"
@ -599,10 +600,10 @@ void ComponentUpdateTask::resolveDependencies(bool checkOnly)
component->m_version = (*minecraft)->getVersion(); component->m_version = (*minecraft)->getVersion();
} }
} }
}
// HACK HACK HACK HACK FIXME: this is a placeholder for deciding what version to use. For now, it is hardcoded. // HACK HACK HACK HACK FIXME: this is a placeholder for deciding what version to use. For now, it is hardcoded.
// ############################################################################################################ // ############################################################################################################
} }
}
component->m_dependencyOnly = true; component->m_dependencyOnly = true;
// FIXME: this should not work directly with the component list // FIXME: this should not work directly with the component list
d->m_list->insertComponent(add.indexOfFirstDependee, component); d->m_list->insertComponent(add.indexOfFirstDependee, component);

2
launcher/minecraft/ComponentUpdateTask.h
View File

@ -2,7 +2,6 @@
#include "tasks/Task.h" #include "tasks/Task.h"
#include "net/Mode.h" #include "net/Mode.h"
#include "Component.h"
#include <memory> #include <memory>
class PackProfile; class PackProfile;
@ -27,7 +26,6 @@ protected:
private: private:
void loadComponents(); void loadComponents();
QString findBestComponentVersion(ComponentPtr component);
void resolveDependencies(bool checkOnly); void resolveDependencies(bool checkOnly);
void remoteLoadSucceeded(size_t index); void remoteLoadSucceeded(size_t index);

1
launcher/ui/pages/instance/ModFolderPage.cpp
View File

@ -390,7 +390,6 @@ void ModFolderPage::on_actionInstall_mods_triggered()
if(m_inst->typeName() != "Minecraft"){ if(m_inst->typeName() != "Minecraft"){
return; //this is a null instance or a legacy instance return; //this is a null instance or a legacy instance
} }
QStringList modLoaders = {"net.minecraftforge", "net.fabricmc.fabric-loader", "org.quiltmc.quilt-loader"};
auto profile = ((MinecraftInstance *)m_inst)->getPackProfile(); auto profile = ((MinecraftInstance *)m_inst)->getPackProfile();
if (profile->getModLoader() == ModAPI::Any) { if (profile->getModLoader() == ModAPI::Any) {
QMessageBox::critical(this,tr("Error"),tr("Please install a mod loader first!")); QMessageBox::critical(this,tr("Error"),tr("Please install a mod loader first!"));