0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix syntax error

Browse Source 
You do not need goto for that. Really.
This commit is contained in:
Petr Mrázek 2013-12-13 02:52:54 +01:00
parent 7d20e2478a
commit 382e4fe6b3
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
logic/updater/DownloadUpdateTask.cpp
View File

@ -239,21 +239,19 @@ void DownloadUpdateTask::processFileLists()
// delete anything in the current one version's list that isn't in the new version's list. // delete anything in the current one version's list that isn't in the new version's list.
for (VersionFileEntry entry : m_cVersionFileList) for (VersionFileEntry entry : m_cVersionFileList)
{ {
bool keep = false;
for (VersionFileEntry newEntry : m_nVersionFileList) for (VersionFileEntry newEntry : m_nVersionFileList)
{ {
if (newEntry.path == entry.path) if (newEntry.path == entry.path)
{ {
QLOG_DEBUG() << "Not deleting" << entry.path << "because it is still present in the new version."; QLOG_DEBUG() << "Not deleting" << entry.path << "because it is still present in the new version.";
goto SkipFile; keep = true;
break;
} }
} }
// If the loop reaches the end, we didn't find a match. Delete the file. // If the loop reaches the end and we didn't find a match, delete the file.
m_operationList.append(UpdateOperation::DeleteOp(entry.path)); if(!keep)
m_operationList.append(UpdateOperation::DeleteOp(entry.path));
SkipFile:
// We goto here from the inner loop if we find an entry that has a corresponding entry in the new version's file list.
// This allows us to effectively continue the outer loop from the inner loop.
// In this case, goto is the more readable option.
} }
// Create a network job for downloading files. // Create a network job for downloading files.