0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only load instance list twice.

Browse Source
This commit is contained in:
Petr Mrázek 2014-02-09 11:00:34 +01:00
parent 583786757a
commit 9022042360
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
logic/lists/MinecraftVersionList.cpp
View File

@ -60,10 +60,15 @@ bool cmpVersions(BaseVersionPtr first, BaseVersionPtr second)
return left->timestamp > right->timestamp; return left->timestamp > right->timestamp;
} }
void MinecraftVersionList::sortInternal()
{
qSort(m_vlist.begin(), m_vlist.end(), cmpVersions);
}
void MinecraftVersionList::sort() void MinecraftVersionList::sort()
{ {
beginResetModel(); beginResetModel();
qSort(m_vlist.begin(), m_vlist.end(), cmpVersions); sortInternal();
endResetModel(); endResetModel();
} }
@ -85,9 +90,8 @@ void MinecraftVersionList::updateListData(QList<BaseVersionPtr> versions)
beginResetModel(); beginResetModel();
m_vlist = versions; m_vlist = versions;
m_loaded = true; m_loaded = true;
sortInternal();
endResetModel(); endResetModel();
// NOW SORT!!
sort();
} }
inline QDomElement getDomElementByTagName(QDomElement parent, QString tagname) inline QDomElement getDomElementByTagName(QDomElement parent, QString tagname)

2
logic/lists/MinecraftVersionList.h
View File

@ -29,6 +29,8 @@ class QNetworkReply;
class MinecraftVersionList : public BaseVersionList class MinecraftVersionList : public BaseVersionList
{ {
Q_OBJECT Q_OBJECT
private:
void sortInternal();
public: public:
friend class MCVListLoadTask; friend class MCVListLoadTask;