0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NOISSUE make sure saving config files is atomic

Browse Source
This commit is contained in:
Petr Mrázek 2015-02-21 00:21:19 +01:00
parent a53f8d506e
commit b8a8b09796
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
logic/settings/INIFile.cpp
View File

@ -18,6 +18,8 @@
#include <QFile> #include <QFile>
#include <QTextStream> #include <QTextStream>
#include <QStringList> #include <QStringList>
#include <QSaveFile>
#include <QDebug>
INIFile::INIFile() INIFile::INIFile()
{ {
@ -72,10 +74,14 @@ QString INIFile::escape(QString orig)
bool INIFile::saveFile(QString fileName) bool INIFile::saveFile(QString fileName)
{ {
// TODO Handle errors. QSaveFile file(fileName);
QFile file(fileName); if(!file.open(QIODevice::WriteOnly))
file.open(QIODevice::WriteOnly); {
QTextStream out(&file); qCritical() << "Unable to open INI config file" << fileName << "for saving";
return false;
}
QByteArray outArray;
QTextStream out(&outArray);
out.setCodec("UTF-8"); out.setCodec("UTF-8");
for (Iterator iter = begin(); iter != end(); iter++) for (Iterator iter = begin(); iter != end(); iter++)
@ -84,7 +90,18 @@ bool INIFile::saveFile(QString fileName)
value = escape(value); value = escape(value);
out << iter.key() << "=" << value << "\n"; out << iter.key() << "=" << value << "\n";
} }
if(file.write(outArray) != outArray.size())
{
qCritical() << "Unable to write to the INI config file" << fileName;
file.cancelWriting();
return false;
}
if(!file.commit())
{
qCritical() << "Unable to commit the INI config file" << fileName;
file.cancelWriting();
return false;
}
return true; return true;
} }