0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: katabasis and QStyle leaks

Browse Source 
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers 2023-05-25 16:16:58 -07:00
parent 6b8fe283f0
commit e61d8e4dc8
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
launcher/ui/pages/instance/ManagedPackPage.cpp
View File

@ -62,8 +62,11 @@ ManagedPackPage::ManagedPackPage(BaseInstance* inst, InstanceWindow* instance_wi
// NOTE: GTK2 themes crash with the proxy style. // NOTE: GTK2 themes crash with the proxy style.
// This seems like an upstream bug, so there's not much else that can be done. // This seems like an upstream bug, so there's not much else that can be done.
if (!QStyleFactory::keys().contains("gtk2")) if (!QStyleFactory::keys().contains("gtk2")){
ui->versionsComboBox->setStyle(new NoBigComboBoxStyle(ui->versionsComboBox->style())); auto comboStyle = new NoBigComboBoxStyle(ui->versionsComboBox->style());
comboStyle->setParent(APPLICATION); // make sure this gets cleaned up (setting to simply `this` causes it to be freed too soon)
ui->versionsComboBox->setStyle(comboStyle);
}
ui->reloadButton->setVisible(false); ui->reloadButton->setVisible(false);
connect(ui->reloadButton, &QPushButton::clicked, this, [this](bool){ connect(ui->reloadButton, &QPushButton::clicked, this, [this](bool){

2
libraries/katabasis/src/Reply.cpp
View File

@ -40,6 +40,8 @@ void ReplyList::remove(QNetworkReply *reply) {
if (o2Reply) { if (o2Reply) {
o2Reply->stop(); o2Reply->stop();
(void)replies_.removeOne(o2Reply); (void)replies_.removeOne(o2Reply);
// we took ownership, we must free
delete o2Reply;
} }
} }