0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers 2023-01-13 13:11:20 -07:00
parent 574af2c795
commit f7b0ba88da
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
launcher/Application.cpp
View File

@ -266,7 +266,8 @@ Application::Application(int &argc, char **argv) : QApplication(argc, argv)
m_zipsToImport.append(QUrl::fromLocalFile(QFileInfo(zip_path).absoluteFilePath())); m_zipsToImport.append(QUrl::fromLocalFile(QFileInfo(zip_path).absoluteFilePath()));
} }
for (auto zip_path : parser.positionalArguments()){ // treat unspesified positional arguments as import urls // treat unspecified positional arguments as import urls
for (auto zip_path : parser.positionalArguments()) {
m_zipsToImport.append(QUrl::fromLocalFile(QFileInfo(zip_path).absoluteFilePath())); m_zipsToImport.append(QUrl::fromLocalFile(QFileInfo(zip_path).absoluteFilePath()));
} }

6
launcher/ui/MainWindow.cpp
View File

@ -1816,7 +1816,7 @@ void MainWindow::processURLs(QList<QUrl> urls)
{ {
// NOTE: This loop only processes one dropped file! // NOTE: This loop only processes one dropped file!
for (auto& url : urls) { for (auto& url : urls) {
qDebug() << "Processing :" << url; qDebug() << "Processing" << url;
// The isLocalFile() check below doesn't work as intended without an explicit scheme. // The isLocalFile() check below doesn't work as intended without an explicit scheme.
if (url.scheme().isEmpty()) if (url.scheme().isEmpty())
@ -1832,9 +1832,7 @@ void MainWindow::processURLs(QList<QUrl> urls)
auto type = ResourceUtils::identify(localFileInfo); auto type = ResourceUtils::identify(localFileInfo);
// bool is_resource = type; if (ResourceUtils::ValidResourceTypes.count(type) == 0) { // probably instance/modpack
if (!(ResourceUtils::ValidResourceTypes.count(type) > 0)) { // probably instance/modpack
addInstance(localFileName); addInstance(localFileName);
continue; continue;
} }