Passing the classpath into stdin has no effect. Java is already provided the classpath with -cp, which pretty much takes up the largest part of the arguments anyway, which leads me to wonder, what's the point of stdin arguments at all?
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Factories in OOP are a classic example of over-enginneering. When you only have two launchers I personally think that it's not very useful.
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
- Makes code formatting more consistent with the C++ codebase. Probably removes some trailing whitespace. Maybe it would be best to commit an Eclipse or IntelliJ code format preferences file?
- Removes obscure suppressions. I personally think it's better to only suppress warnings that javac complains about. Suppressing a lot of non-standardised warnings (many of them turned off by default even in IntelliJ) just creates needless clutter.
- Fixes some trivial warnings instead of suppressing them. serialVersionUID is sort of stupid, but I'd rather mentally ignore it or just fix it if it's really that annoying.
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
- Update license headers in several files to remove multimc apache reference, when unneeded
- LauncherFactory: we've entirely rewritten this class at this point, so it's fully under GPL code
- Launcher: this interface contains zero logic, and only a single method named `launch`, so I doubt you can actually copyright that
- LauncherProvider: same as above
- ParseException, ParameterNotFoundException: same as above; this class contains almost no logic (And the logic that was added is under GPL)
- ReflectionUtils, StringUtils: add license header
- Everything else: modify the program name in the license header from "PolyMC - Minecraft Launcher" to "Prism Launcher"
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
Cleanup a bunch of the code in launcher classes
- Migrate the majority of the reflection to ReflectionUtils
- Decrease logic in AbstractLauncher
- Add logging to launcher classes at FINE level
- make mcParams in AbstractLauncher an immutable list to prevent runtime manipulation
- StandardLauncher instead copies the list to modify it
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
No code logic has been changed, only:
- add @Override annotatons
- change setVisible(boolean b) -> setVisible(boolean visible)
- Change block commend on class -> javadoc comment
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
- Don't return an int from listen(). An enum is preferred.
- Make parseLine() static, and pass Parameters to it.
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
We were not propagating the '--demo' flag in the legacy launcher,
unconditionally setting the 'demo' parameter to false.
Signed-off-by: flow <flowlnlnln@gmail.com>
Using `Collections.emptyList()` doesn't allow us to later append stuff
into that list. Use an empty `ArrayList` instead.
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
