0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4a8abc948e
pollymc/launcher
History
flow 4a8abc948e
fix: prevent segfault due to callbacks into deleted objects 
Since network requests are, for the most part, asynchronous, there's a
chance a request only comes through after the request sender has already
been deleted.

This adds a global (read static) hash table relating models for the mod
downloader to their status (true = alive, false = destroyed). It is a
bit of a hack, but I couldn't come up with a better way of doing this.

To reproduce the issue before this commit: scroll really quickly through
CF mods, to trigger network requests for their versions and description.
Then, in the middle of it close the mod downloader. Sometimes this will
create a crash.

Signed-off-by: flow <flowlnlnln@gmail.com>
2022-08-01 18:34:15 -03:00
..
icons chore: update license headers 2022-07-10 12:19:15 +02:00
java Merge pull request #893 from Scrumplex/refactor-env-handling 2022-07-23 14:08:10 +02:00
launch fix: actually substitute variables in pre/post launch 2022-07-23 17:51:58 +02:00
meta refactor: move away from UnitTest.cmake 2022-06-14 14:44:49 +02:00
minecraft Merge pull request #941 from Scrumplex/bump-cxx-standard 2022-07-30 17:10:59 +01:00
modplatform feat: lazy-load CF mod descriptions 2022-08-01 07:33:30 -03:00
mojang refactor: move away from UnitTest.cmake 2022-06-14 14:44:49 +02:00
net Merge pull request #877 from Scrumplex/refactor-offline-accounts 2022-07-23 13:54:36 +02:00
news chore: update license headers 2022-07-10 12:19:15 +02:00
pathmatcher
resources change cf icon to a more fancy one 2022-05-21 17:49:52 +02:00
screenshots chore: update license headers 2022-07-10 12:19:15 +02:00
settings chore: update license headers 2022-07-10 12:19:15 +02:00
tasks feat: add MultipleOptionsTask 2022-07-17 11:33:41 -03:00
testdata
tools Add OpenBSD support 2022-06-02 02:02:42 +10:00
translations chore: update license headers 2022-07-10 12:19:15 +02:00
ui fix: prevent segfault due to callbacks into deleted objects 2022-08-01 18:34:15 -03:00
updater Remove use of obsolete method 2022-07-10 19:09:58 -04:00
Application.cpp feat(ui): remember mod download dialog's geometry 2022-08-01 07:33:31 -03:00
Application.h Merge pull request #678 from Scrumplex/improvements-around-proprietary-services 2022-07-11 14:56:09 +02:00
ApplicationMessage.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
ApplicationMessage.h
BaseInstaller.cpp
BaseInstaller.h
BaseInstance.cpp refactor: replace QRegExp with QRegularExpression 2022-07-10 12:17:52 +02:00
BaseInstance.h Add Performance related settings 2022-07-06 09:34:14 +02:00
BaseVersion.h
BaseVersionList.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
BaseVersionList.h
CMakeLists.txt feat: create delegate for project item views 2022-08-01 07:33:29 -03:00
Commandline.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
Commandline.h
DefaultVariable.h
DesktopServices.cpp
DesktopServices.h
Exception.h
ExponentialSeries.h
FileSystem_test.cpp refactor: move away from UnitTest.cmake 2022-06-14 14:44:49 +02:00
FileSystem.cpp Trash instances instead of deleting (when possible) (#549) 2022-07-30 14:42:33 -03:00
FileSystem.h Trash instances instead of deleting (when possible) (#549) 2022-07-30 14:42:33 -03:00
Filter.cpp
Filter.h
GZip_test.cpp refactor: move away from UnitTest.cmake 2022-06-14 14:44:49 +02:00
GZip.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
GZip.h
HoeDown.h
install_prereqs.cmake.in
InstanceCopyTask.cpp
InstanceCopyTask.h
InstanceCreationTask.cpp
InstanceCreationTask.h
InstanceImportTask.cpp refactor: replace QRegExp with QRegularExpression 2022-07-10 12:17:52 +02:00
InstanceImportTask.h refactor!: bump to C++17 and C17 2022-07-20 14:22:10 +02:00
InstanceList.cpp Trash instances instead of deleting (when possible) (#549) 2022-07-30 14:42:33 -03:00
InstanceList.h Trash instances instead of deleting (when possible) (#549) 2022-07-30 14:42:33 -03:00
InstancePageProvider.h refactor: Create a more clear hierarchy for some instance pages 2022-06-14 07:04:31 -03:00
InstanceTask.cpp
InstanceTask.h
JavaCommon.cpp fix: add missing full-stop to message 2022-07-16 21:26:23 +02:00
JavaCommon.h feat: resolve JARs dynamically 2022-07-03 17:31:01 +02:00
Json.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
Json.h chore: update license headers 2022-07-10 12:19:15 +02:00
KonamiCode.cpp
KonamiCode.h
LaunchController.cpp fix: do not show the "profile select" dialog if the user refused to add an account 2022-05-30 13:33:07 +03:00
LaunchController.h
Launcher.in refactor: filter values in environment variables 2022-07-19 18:07:58 +02:00
LoggedProcess.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
LoggedProcess.h chore: update license headers 2022-07-10 12:19:15 +02:00
main.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
MessageLevel.cpp
MessageLevel.h
MMCStrings.cpp
MMCStrings.h
MMCTime.cpp
MMCTime.h
MMCZip.cpp Merge pull request #941 from Scrumplex/bump-cxx-standard 2022-07-30 17:10:59 +01:00
MMCZip.h refactor!: bump to C++17 and C17 2022-07-20 14:22:10 +02:00
ModDownloadTask.cpp change: mod metadata improvements 2022-07-17 11:33:43 -03:00
ModDownloadTask.h feat: remove existing mod when updating/redownloading it 2022-07-17 11:33:42 -03:00
NullInstance.h Add Performance related settings 2022-07-06 09:34:14 +02:00
ProblemProvider.h
QObjectPtr.h fix: use const qualifier for operator==() and allow other comparisons 2022-07-26 15:11:56 -03:00
RecursiveFileSystemWatcher.cpp
RecursiveFileSystemWatcher.h
RWStorage.h
SeparatorPrefixTree.h
SkinUtils.cpp
SkinUtils.h
UpdateController.cpp Add OpenBSD support 2022-06-02 02:02:42 +10:00
UpdateController.h
Usable.h
Version_test.cpp
Version.cpp
Version.h chore: update license headers 2022-07-10 12:19:15 +02:00
VersionProxyModel.cpp chore: update license headers 2022-07-10 12:19:15 +02:00
VersionProxyModel.h
WatchLock.h