8409aa2571
The checks used are roughly the same as the ones proposed in the clang-tidy PR (except perhaps that I used modernize-* instead of listing them individually,though I don't think this caused any readability detriments). In ModrinthModel.cpp and FlameModModel.cpp I ignored the modernize-avoid-c-arrays one, mostly because making the sorts array an std::array would most likely increase the code complexity because of the virtual function. Aside from that, the static_cast warning from Application.h was not dealt with, since it's not in this PR's scope.
37 lines
1.7 KiB
C++
37 lines
1.7 KiB
C++
#include "ModrinthPage.h"
|
|
#include "ui_ModPage.h"
|
|
|
|
#include "ModrinthModel.h"
|
|
#include "ui/dialogs/ModDownloadDialog.h"
|
|
|
|
ModrinthPage::ModrinthPage(ModDownloadDialog* dialog, BaseInstance* instance)
|
|
: ModPage(dialog, instance, new ModrinthAPI())
|
|
{
|
|
listModel = new Modrinth::ListModel(this);
|
|
ui->packView->setModel(listModel);
|
|
|
|
// index is used to set the sorting with the modrinth api
|
|
ui->sortByBox->addItem(tr("Sort by Relevence"));
|
|
ui->sortByBox->addItem(tr("Sort by Downloads"));
|
|
ui->sortByBox->addItem(tr("Sort by Follows"));
|
|
ui->sortByBox->addItem(tr("Sort by last updated"));
|
|
ui->sortByBox->addItem(tr("Sort by newest"));
|
|
|
|
// sometimes Qt just ignores virtual slots and doesn't work as intended it seems,
|
|
// so it's best not to connect them in the parent's contructor...
|
|
connect(ui->sortByBox, SIGNAL(currentIndexChanged(int)), this, SLOT(triggerSearch()));
|
|
connect(ui->packView->selectionModel(), &QItemSelectionModel::currentChanged, this, &ModrinthPage::onSelectionChanged);
|
|
connect(ui->versionSelectionBox, &QComboBox::currentTextChanged, this, &ModrinthPage::onVersionSelectionChanged);
|
|
connect(ui->modSelectionButton, &QPushButton::clicked, this, &ModrinthPage::onModSelected);
|
|
}
|
|
|
|
auto ModrinthPage::validateVersion(ModPlatform::IndexedVersion& ver, QString mineVer, QString loaderVer) const -> bool
|
|
{
|
|
return ver.mcVersion.contains(mineVer) && ver.loaders.contains(loaderVer);
|
|
}
|
|
|
|
// I don't know why, but doing this on the parent class makes it so that
|
|
// other mod providers start loading before being selected, at least with
|
|
// my Qt, so we need to implement this in every derived class...
|
|
auto ModrinthPage::shouldDisplay() const -> bool { return true; }
|