d2fdbec41d
This makes it harder for problems in the updating process to affect the current instance. Network issues, for instance, will no longer put the instance in an invalid state. Still, a possible improvement to this would be passing that logic to InstanceStaging instead, to be handled with the instance commiting directly. However, as it is now, the code would become very spaguetti-y, and given that the override operation in the commiting could also put the instance into an invalid state, it seems to me that, in order to fully error-proof this, we would need to do a copy operation on the whole instance, in order to modify the copy, and only in the end override everything an once with a rename. That also has the possibility of corrupting the instance if done without super care, however, so I think we may need to instead create an automatic backup system, with an undo command of sorts, or something like that. This doesn't seem very trivial though, so it'll probably need to wait until another PR. In the meantime, the user is advised to always backup their instances before doing this kind of action, as always. What a long commit message o.O Signed-off-by: flow <flowlnlnln@gmail.com> |
||
|---|---|---|
| .. | ||
| icons | ||
| java | ||
| launch | ||
| meta | ||
| minecraft | ||
| modplatform | ||
| mojang | ||
| net | ||
| news | ||
| pathmatcher | ||
| resources | ||
| screenshots | ||
| settings | ||
| tasks | ||
| tools | ||
| translations | ||
| ui | ||
| updater | ||
| Application.cpp | ||
| Application.h | ||
| ApplicationMessage.cpp | ||
| ApplicationMessage.h | ||
| BaseInstaller.cpp | ||
| BaseInstaller.h | ||
| BaseInstance.cpp | ||
| BaseInstance.h | ||
| BaseVersion.h | ||
| BaseVersionList.cpp | ||
| BaseVersionList.h | ||
| CMakeLists.txt | ||
| Commandline.cpp | ||
| Commandline.h | ||
| DefaultVariable.h | ||
| DesktopServices.cpp | ||
| DesktopServices.h | ||
| Exception.h | ||
| ExponentialSeries.h | ||
| FileSystem.cpp | ||
| FileSystem.h | ||
| Filter.cpp | ||
| Filter.h | ||
| GZip.cpp | ||
| GZip.h | ||
| HoeDown.h | ||
| install_prereqs.cmake.in | ||
| InstanceCopyTask.cpp | ||
| InstanceCopyTask.h | ||
| InstanceCreationTask.cpp | ||
| InstanceCreationTask.h | ||
| InstanceImportTask.cpp | ||
| InstanceImportTask.h | ||
| InstanceList.cpp | ||
| InstanceList.h | ||
| InstancePageProvider.h | ||
| InstanceTask.cpp | ||
| InstanceTask.h | ||
| JavaCommon.cpp | ||
| JavaCommon.h | ||
| Json.cpp | ||
| Json.h | ||
| KonamiCode.cpp | ||
| KonamiCode.h | ||
| LaunchController.cpp | ||
| LaunchController.h | ||
| Launcher.in | ||
| LoggedProcess.cpp | ||
| LoggedProcess.h | ||
| main.cpp | ||
| MessageLevel.cpp | ||
| MessageLevel.h | ||
| MMCStrings.cpp | ||
| MMCStrings.h | ||
| MMCTime.cpp | ||
| MMCTime.h | ||
| MMCZip.cpp | ||
| MMCZip.h | ||
| ModDownloadTask.cpp | ||
| ModDownloadTask.h | ||
| NullInstance.h | ||
| ProblemProvider.h | ||
| QObjectPtr.h | ||
| RecursiveFileSystemWatcher.cpp | ||
| RecursiveFileSystemWatcher.h | ||
| RWStorage.h | ||
| SeparatorPrefixTree.h | ||
| SkinUtils.cpp | ||
| SkinUtils.h | ||
| UpdateController.cpp | ||
| UpdateController.h | ||
| Usable.h | ||
| Version.cpp | ||
| Version.h | ||
| VersionProxyModel.cpp | ||
| VersionProxyModel.h | ||
| WatchLock.h | ||